-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release to home-assistant #15
Comments
Honestly I don't have confidence in my python or home assistant knowledge to do it but I have happy for anyone to take my code as a starting point |
Hey guys, as the first step to this I have started creating the python module for the OpenSprinkler API. I am not very experienced with python so please bear with me. Any help is appreciated. |
For reference: home-assistant/core#34146 |
Seeing lots of activity there. It's appreciated! |
I came across OpenSprinkler in the integrations menu. So almost there I guess 👍 But it didn't work and the README still suggests the HACS method. Should we update the README or is HACS still the prefered method? edit: nevermind. I removed it from HACS and the integration was gone. My bad. |
@travisghansen or @vinteo I'm looking forward to your official integration into Home Assistant. Last I can see, two months ago you guys were doing a bigger overhaul (as referenced in home-assistant/core#34146 (comment)) and the original PR was closed as stale last month. Is there anything we could help with? |
The is probably pretty well settled at this point and we could revisit.. |
Hi all, just thought I would share some of my thoughts here about this. Adding this integration as a core integration within HA will bring extra responsibilities, most of all the pressure to fix ASAP when something goes wrong or when there is breaking change on HA. On the flip side as a core integration maybe it will gather more attention and more contributions than we currently have (not that I don't appreciate all the contributions so far, thanks everyone!). However either way, when you act as the core maintainer there is that responsibility there and I am not sure I have the time (or motivation?) to do it. I certainly don't like it when a core integration breaks and it doesn't get fixed, luckily most of the integrations I use are pretty mainstream. With HACS, I feel like the integration is easy to install and for me to release versions but it still comes with the caveat that it may not be as maintained as a core integration. And this works for my situation and the time I can devote to it. As you can see there are long periods of inactivity sometimes. Anyway my point is that this will most likely not become a core integration with me as the core maintainer. I have always said that I am happy for my (our) code to be used for a core integration as long as someone is happy to take on the responsibility as the core maintainer and I still maintain this stance. Volunteers anyone? 😃 But I am not saying I will stop maintaining this integration, I will continue to devote some time whenever I can for now (and I do try to fix breaking issues as soon as I can), and this only works as a custom integration for me. Thanks |
Hello,
Do you have any intention of releasing this to home-assistant so we don't need a custom component?
The text was updated successfully, but these errors were encountered: