Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Split vitalizer and modules into individual repositories #568

Open
tyru opened this issue Dec 27, 2017 · 7 comments
Open

[RFC] Split vitalizer and modules into individual repositories #568

tyru opened this issue Dec 27, 2017 · 7 comments
Assignees

Comments

@tyru
Copy link
Member

tyru commented Dec 27, 2017

via https://vim-jp.slackarchive.io/general/page-40/ts-1514306851000160

Repositories

See #568 (comment)

  • vim-jp/vital.vim - Vitalizer only
  • vim-jp/vital-core.vim - Core modules
  • vim-jp/vital-supplement.vim - Supplement modules

Vitalizer clones external repositories

  • Vitalize --repo=vim-jp/vital-core.vim {dir}
  • vim-jp/vital-core.vim is the default repository (does not have to specify it explicitly)
  • The specified repositories list are stored in autoload/vital/{name}.repo file so the next time users don't have to specify repositories twice
    • Can the list be written in autoload/vital/{name}.vital file with keeping the compatibility of the current format?
@ujihisa
Copy link
Member

ujihisa commented Dec 31, 2017

The original reason why I started vital.vim both with vitalizer and modules in a same repository was just for convenience. I agree 👍 with splitting them if it helps our development significantly.

I guess it's also a time to create a vital.vim organization, either at https://github.com/vital or https://github.com/vitalvim (I hoped https://github.com/vital.vim was available though.)

  • vital/vital.vim - Vitalizer only
  • vital/vital-core.vim - Core modules that even vitalizer depends on
  • vital/vital-supplement.vim - Supplement modules (i.e. current vital.vim modules except for above)

@lambdalisue
Copy link
Member

+1 for organization!

@tyru
Copy link
Member Author

tyru commented Dec 31, 2017

organization 👍

However, I don't think vim prefix or suffix is necessary if organization name already has "vim".

  • vim-vital/vitalizer - Vitalizer only
  • vim-vital/vital-core - Core modules that even vitalizer depends on
  • vim-vital/vital-supplement - Supplement modules (i.e. current vital.vim modules except for above)

I think vital module repository should (not must) have "vital-" prefix, because it indicates "vital module" to vim or vital users (e.g.: webpack loader has "-loader" suffix).

@tyru
Copy link
Member Author

tyru commented Feb 27, 2018

:Vitalize する際に毎回リポジトリを git clone するのか、またはキャッシュ用ディレクトリに置くとしたらどこに置くのか、といった事を決める必要があると思います。
例: ~/.vitalizer/cache/github.com/{user}/{repo}

@tyru
Copy link
Member Author

tyru commented Mar 1, 2018

キャッシュ用ディレクトリはこの node モジュールと同じにすると良さそうです。
各プラットフォームで最適なディレクトリを探してくれてるっぽいです。
例えば Unix 系だったら
~/.cache/{appname} とか。

https://www.npmjs.com/package/cache-directory
https://github.com/strugee/node-cache-directory/blob/master/index.js

参考

XDG Base Directory Specification
https://standards.freedesktop.org/basedir-spec/latest/ar01s03.html

@tyru
Copy link
Member Author

tyru commented Jun 11, 2018

多分リポジトリの存在も知らない人が多いと思うので、こっちからリンク貼って周知しておきます。 vim-vital/vital-core#1

このリポジトリの経緯としては、 #577 の vital 開発者会議 2018-03 (参加者: @lambdalisue, @thinca, @ujihisa, @tyru) の時にこの issue の話が上がり、organization だけでも取っておこうという事になって作ったリポジトリです。
まだ移行も終わっていないため、このリポジトリで話し合いを進めていくのかどうかは検討の余地がありそうですが、とりあえず周知だけ。

@tyru
Copy link
Member Author

tyru commented Jun 11, 2018

Translated above comment.


vim-vital/vital-core#1
Maybe most people here don't know the organization & repository, I just want to share them.

The repository was created on vital developer meeting 2018-03 (participant: @lambdalisue, @thinca, @ujihisa, @tyru).
This issue (#568) was discussed and we took the organization namespace then.

This is my personal opinion.
I think it's necessary to discuss if we use there now.
because we don't move the repository yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants