Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking node.js 16 change in 0.4.172 #1663

Closed
arthurgailes opened this issue May 30, 2024 · 4 comments
Closed

Breaking node.js 16 change in 0.4.172 #1663

arthurgailes opened this issue May 30, 2024 · 4 comments
Labels

Comments

@arthurgailes
Copy link
Contributor

Description

Hello,

Upgrading from 171 to 172 returns the following error. Not sure if this is a bug or a documentation issue.

Error: [vike][Wrong Usage] Node.js 16.18.0 isn't supported, use Node.js >= 18.0.0 instead.
    at assertVersion (file:///mypath/Documents/sites/aei-js-monorepo/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/vike/dist/esm/utils/assertVersion.js:5:5)
    at assertNodeVersion (file:///mypath/Documents/sites/aei-js-monorepo/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/vike/dist/esm/utils/assertNodeVersio    at onLoad (file:///mypath/Documents/sites/aei-js-monorepo/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/vike/dist/esm/node/runtime/onLoad.js:7:5)      
    at file:///mypath/Documents/sites/aei-js-monorepo/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/vike/dist/esm/node/runtime/utils.js:4:1
    at async Promise.all (index 0)
@brillout
Copy link
Member

Node.js 16 is EOL and thus not supported anymore.

@brillout brillout closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
@arthurgailes
Copy link
Contributor Author

Thank you, that makes sense. Could you add it to the changelog? It is a change in vike's programming between versions, and it does break an existing feature. The vite docs list this in the major update, for example: https://vitejs.dev/guide/migration

@brillout
Copy link
Member

I agree and the plan is to be more strict regarding breaking changes starting from v1.0.0. Maybe/tentatively the V1 won't have any major breaking changes for years (since Vike core is decoupled from the UI framework), but let's see how things evolve.

Btw. would your company be up for sponsoring? As you can imagine, getting the overall architecture and all the details right isn't trivial, to say the least. Any help from companies is massively appreciated!

@arthurgailes
Copy link
Contributor Author

I'm sorry, but mine is mostly a solo project. If I have a feature request in the future, I might be able to send you a small one-time donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants