-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue Devtools-Next errors when trying to evaluate pageContext #160
Comments
Thank you for raising the issue. The If |
Maybe the whitelisting should be established together with the devtools team, so that is they check for something new they should notify in the vike repo. |
I agree, although I ain't sure how much interest they'll show in maintaining such list 🤔 Maybe it's worth a try. |
I'll make a simple repo showing the problem and open an issue on their repo referencing this issue. |
👍 |
I would prefer a warning instead of assertUsage as well. Right now this error prevents the Vue devtools from listing the component contents entirely whenever PageContext is used. |
@martijndirksen Yea, let's give whitelisting a last chance and if we can't make it work then let's make it a warning. (Thanks for sponsonring btw! 💚) |
@brillout Can you please take over the technical part here? |
@pdanpdan Done 👍 |
Fixed in devtools |
Neat, thank you for reaching out @pdanpdan |
This is the plan so far: vikejs/vike#1776. |
I'm not sure if this should be solved in
vike
or indevtools-next
(https://github.com/vuejs/devtools-next) or in both.When inspecting components that use
usePageContext
inscript setup
devtools will try to check some marker/well-known keys for internal purposes inprepare.js
.This will produce calls to
getPageContextProxyForUser
for keyrender
at least, and that will produce an[vike][Wrong Usage] pageContext.render isn't defined on the client-side
error.It looks like normal (non-next) vue devtools works.
@brillout Maybe this should be forwarded to the vue devtools team, but I think you can decide better.
The text was updated successfully, but these errors were encountered: