You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey! I noticed that on this personal project of mine my <title> tag is getting emptied each time on client-side navigation. I only have a +Head.tsx file defined at root so should't be overridden by any page.
Digging into the onRenderClient.tsx I noticed that the title var that comes from the pageContext.configEntries is being set to an empty string if it returns a falsy value, so it always updates the head <title> tag. Wondering if it's safe removing this || '' at the end of the line.
Hey! I noticed that on this personal project of mine my <title> tag is getting emptied each time on client-side navigation. I only have a
+Head.tsx
file defined at root so should't be overridden by any page.Digging into the
onRenderClient.tsx
I noticed that thetitle
var that comes from thepageContext.configEntries
is being set to an empty string if it returns a falsy value, so it always updates the head <title> tag. Wondering if it's safe removing this|| ''
at the end of the line.https://github.com/vikejs/vike-react/blob/bdf9e088902821e14e6bf76fcb6a9769347392fd/packages/vike-react/src/renderer/onRenderClient.tsx#L59C53-L59C59
The text was updated successfully, but these errors were encountered: