tools-calibrate not compatible with klipper after cc6736c

[benecito]

After updating klipper (and klipper-toolchanger) I run into a
Internal error on command:"TOOL_LOCATE_SENSOR"
when trying to run a calibration.
I was able to pinpoint the commit it stopped working (Klipper3d/klipper@cc6736c) but it's a little beyond my current knowledge to find the actual reason.

[benecito]

sorry - forgot to include the following:

Probe made contact at 269.321875,398.946875,1.143277
run_probe direction = x+
run_probe axis = 0, sense = 1
Internal error on command:"TOOL_LOCATE_SENSOR"
Traceback (most recent call last):
  File "/home/pi/klipper/klippy/gcode.py", line 212, in _process_commands
    handler(gcmd)
  File "/home/pi/klipper/klippy/gcode.py", line 140, in <lambda>
    func = lambda params: origfunc(self._get_extended_params(params))
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/tools_calibrate.py", line 116, in cmd_TOOL_LOCATE_SENSOR
    self.last_result = self.locate_sensor(gcmd)
                       ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/tools_calibrate.py", line 89, in locate_sensor
    center_x, center_y = self.calibrate_xy(toolhead, downPos, gcmd,
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/tools_calibrate.py", line 79, in calibrate_xy
    left_x = self.probe_xy(toolhead, top_pos, 'x+', gcmd, samples=samples)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/tools_calibrate.py", line 74, in probe_xy
    return self.probe_multi_axis.run_probe(direction, gcmd, samples=samples,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/tools_calibrate.py", line 320, in run_probe
    pos = self._probe(speed, axis, sense, max_distance)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/tools_calibrate.py", line 242, in _probe
    epos = phoming.probing_move(self.mcu_probe[axis], pos, speed)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/homing.py", line 264, in probing_move
    hmove = HomingMove(self.printer, endstops)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/homing.py", line 48, in __init__
    self.endstops = [es for es in endstops if es[0].get_steppers()]
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/homing.py", line 48, in <listcomp>
    self.endstops = [es for es in endstops if es[0].get_steppers()]
                                              ^^^^^^^^^^^^^^^^^^^^
  File "/home/pi/klipper/klippy/extras/tools_calibrate.py", line 367, in _get_steppers
    prime_rail = dual_carriage.get_primary_rail()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: DualCarriages.get_primary_rail() missing 1 required positional argument: 'axis'
Transition to shutdown state: Internal error on command:"TOOL_LOCATE_SENSOR"

[TTom1088]

I have the same problem. I am using an Idex printer (Tridex) in hybrid Core XY design. Calibration currently only works when I use an older version of Klipper.

[Dan3dp]

had the same thing

see: #95

redo your configs using 'generic_cartesian' kinematics

[TTom1088]

Where does the information for changing to "generic_cartesian" come from?
I have a "hybrid_corexy," so this setting type won't work.

[fsironman]

I created a pull request that fixed the problem on my Tridex: #100

[TTom1088]

@fsironman Great, then I thank you for that and hope that everything works after the update.

[benecito]

thanks for all the work - especially @fsironman . Unfortunately it seems to only fix it half way as mentioned here: #100 (comment) I didn't have a chance to test it myself but will do so as soon as I find time.

[TTom1088]

@fsironman My Tridex (hybrid_corexy) is now running smoothly again since the update. Good work. Thanks again.

[mandela64]

@benecito I figured out a solution for generic_cartesian and also tested it with hybrid_corexy config.

self.idex = config.has_section('dual_carriage') or config.has_section('dual_carriage u')