Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide deterministic module name for Java 9 module support #137

Open
vicasong opened this issue May 27, 2021 · 4 comments
Open

Provide deterministic module name for Java 9 module support #137

vicasong opened this issue May 27, 2021 · 4 comments

Comments

@vicasong
Copy link

Please provide a deterministic module name by adding Automatic-Module-Name to the manifest.
See :
https://dzone.com/articles/automatic-module-name-calling-all-java-library-maintainers for a rationale.

And now I get an error: Package 'se.vidstige.jadb' is declared in module with an invalid name ('jadb.v1.2.1')

@vidstige
Copy link
Owner

I didn't know about this, thanks for reporting. I'll look into it if/when I find some time. Feel free to add a pull request if you want to! :)

@adamoutler
Copy link

This affects my project as well. I have forked and am maintaining jadb as a part of my Java11 codebase due to lack of module support.

@adamoutler
Copy link

I did the work to do the whole upgrade to Java11 here, @vidstige . I closed the PR because it seemed you were not interested. You may use this as a reference. #140

@vidstige
Copy link
Owner

No, I just missed that PR. I don't check in regularly. There are lots of unrelated changes. Also for a library like this it's good to not be on the latest and greatest (this is normally the best) as that prevents people from upgrading this library and so on. I don't know what a reasonable version to be on is. It would be interesting to have some statistics on how widely used Java 11 is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants