Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Broken link in changelog at 8.19.0 #8967

Open
BrainCrumbz opened this issue Jan 23, 2025 · 1 comment
Open

[docs] Broken link in changelog at 8.19.0 #8967

BrainCrumbz opened this issue Jan 23, 2025 · 1 comment

Comments

@BrainCrumbz
Copy link
Contributor

BrainCrumbz commented Jan 23, 2025

Current version of changelog document (this) has a broken link to an issue.

The interested section is for release 8.19.0, here:

Image

That 1000#0 link.

Also, just noticed that there are more and more instances of that down the page, e.g. for latest release 8.2.11, all closed issues in 8.18.0, etc.

HTH

@mister-ben
Copy link
Contributor

The ones that have this have the starter template URLhttps://codepen.io/gkatsev/pen/GwZegv?editors=1000#0 in the commit message.

gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/videojs/video.js/commits/c1a8cbf \
  | jq '.commit.message'
"chore: Enable supply chain security through npm provenance attestation (#8911)\n\n## Description\r\n\r\n- Configure GitHub Actions workflow for secure publishing\r\n- Enable automatic provenance generation during npm publish\r\n- Add integrity verification through Sigstore transparency logs\r\n\r\nFollowing the recent Lottie-Player supply chain attack, it's crucial to\r\nenhance package security. NPM provenance provides cryptographic proof\r\nthat this package was built from this repository using GitHub Actions,\r\nmaking supply chain attacks significantly harder. More info in my blog\r\npost\r\nhttps://medium.com/exaforce/npm-provenance-the-missing-security-layer-in-popular-javascript-libraries-b50107927008\r\n\r\n## Specific Changes proposed\r\nChanges the workflow github to publish provenance attestation on\r\nhttps://www.npmjs.com/package/video.js\r\n\r\n## Requirements Checklist\r\n- [x] Feature implemented in CI/CD\r\n- [ ] If necessary, more likely in a feature request than a bug fix\r\n- [ ] Change has been verified in an actual browser (Chrome, Firefox,\r\nIE)\r\n  - [x] Unit Tests updated or fixed\r\n  - [ ] Docs/guides updated\r\n- [ ] Example created ([starter template on\r\nJSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))\r\n- [ x Has no DOM changes which impact accessiblilty or trigger warnings\r\n(e.g. Chrome issues tab)\r\n  - [x] Has no changes to JSDoc which cause `npm run docs:api` to error\r\n- [ ] Reviewed by Two Core Contributors"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants