Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_product_type using product_type interface #13

Open
viboes opened this issue Sep 10, 2016 · 0 comments
Open

Fix is_product_type using product_type interface #13

viboes opened this issue Sep 10, 2016 · 0 comments

Comments

@viboes
Copy link
Owner

viboes commented Sep 10, 2016

is_product_type is defined now as follows

  template <typename T>
  struct is_product_type : is_base_of<product_type_tag, product_type_traits<T>> {};

and force the specialization to inherit from product_type_tag. This is intrusive and don't check all. The definition should probe that the specialization product_type_traits<T> provides the good interface instead, or better yet that the product_type interface is respected.

The advantage of the tag however is that it improves compile time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant