Skip to content

Commit 705b59d

Browse files
committed
PR comments
1 parent a51e4e0 commit 705b59d

File tree

1 file changed

+2
-15
lines changed

1 file changed

+2
-15
lines changed

Diff for: proto/viam/app/v1/app.proto

+2-15
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,6 @@ service AppService {
190190
// Gets a single fragment
191191
rpc GetFragment(GetFragmentRequest) returns (GetFragmentResponse);
192192

193-
// Gets usage for a fragment across versions
194-
rpc GetFragmentUsage(GetFragmentUsageRequest) returns (GetFragmentUsageResponse);
195-
196193
// Creates a fragment
197194
rpc CreateFragment(CreateFragmentRequest) returns (CreateFragmentResponse);
198195

@@ -836,8 +833,6 @@ message FragmentRevision {
836833
message FragmentTag {
837834
string tag = 1;
838835
string revision = 2;
839-
google.protobuf.Timestamp created_at = 3;
840-
google.protobuf.Timestamp updated_at = 4;
841836
}
842837

843838
enum FragmentVisibility {
@@ -867,7 +862,7 @@ message FragmentUsage {
867862
int32 organizations = 2;
868863
int32 machines = 3;
869864
int32 machines_in_current_org = 4;
870-
string version = 5;
865+
optional string version = 5; // revision or tag
871866
}
872867

873868
message ResolvedFragment {
@@ -890,7 +885,7 @@ message ListFragmentsResponse {
890885
message GetFragmentRequest {
891886
string id = 1;
892887
string current_organization_id = 2;
893-
optional string version = 3;
888+
optional string version = 3; // revision or tag
894889
}
895890

896891
message GetFragmentResponse {
@@ -900,14 +895,6 @@ message GetFragmentResponse {
900895
repeated FragmentTag tags = 4;
901896
}
902897

903-
message GetFragmentUsageRequest {
904-
string fragment_id = 1;
905-
}
906-
907-
message GetFragmentUsageResponse {
908-
repeated FragmentUsage version_usages = 1;
909-
}
910-
911898
message CreateFragmentRequest {
912899
string name = 1;
913900
google.protobuf.Struct config = 2;

0 commit comments

Comments
 (0)