Skip to content

Commit 4c32e21

Browse files
committed
Revert addition of iceParameters in "connect" event
1 parent ffc84f6 commit 4c32e21

File tree

4 files changed

+11
-21
lines changed

4 files changed

+11
-21
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"debug": "^4.3.4",
7272
"event-target-shim": "^6.0.2",
7373
"fake-mediastreamtrack": "^1.2.0",
74-
"mediasoup-client": "^3.7.3",
74+
"mediasoup-client": "^3.7.4",
7575
"netstring": "^0.3.0",
7676
"sdp-transform": "^2.14.2",
7777
"uuid": "^9.0.1"

src/Handler.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1173,11 +1173,6 @@ export class Handler extends HandlerInterface {
11731173
localSdpObject = sdpTransform.parse(offer.sdp);
11741174
}
11751175

1176-
// Get our local ICE parameters.
1177-
const iceParameters = sdpCommonUtils.extractIceParameters({
1178-
sdpObject: localSdpObject,
1179-
});
1180-
11811176
// Get our local DTLS parameters.
11821177
const dtlsParameters = sdpCommonUtils.extractDtlsParameters({
11831178
sdpObject: localSdpObject,
@@ -1193,12 +1188,7 @@ export class Handler extends HandlerInterface {
11931188

11941189
// Need to tell the remote transport about our parameters.
11951190
await new Promise<void>((resolve, reject) => {
1196-
this.safeEmit(
1197-
'@connect',
1198-
{ iceParameters, dtlsParameters },
1199-
resolve,
1200-
reject
1201-
);
1191+
this.safeEmit('@connect', { dtlsParameters }, resolve, reject);
12021192
});
12031193

12041194
this.#transportReady = true;

src/test/test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ beforeEach(async () => {
5050
ctx.connectedSendTransport.on(
5151
'connect',
5252
// eslint-disable-next-line no-shadow, @typescript-eslint/no-unused-vars
53-
({ iceParameters, dtlsParameters }, callback /* errback */) => {
53+
({ dtlsParameters }, callback /* errback */) => {
5454
setTimeout(callback);
5555
}
5656
);
@@ -88,7 +88,7 @@ beforeEach(async () => {
8888
ctx.connectedRecvTransport.on(
8989
'connect',
9090
// eslint-disable-next-line no-shadow, @typescript-eslint/no-unused-vars
91-
({ iceParameters, dtlsParameters }, callback /* errback */) => {
91+
({ dtlsParameters }, callback /* errback */) => {
9292
setTimeout(callback);
9393
}
9494
);

0 commit comments

Comments
 (0)