Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I18n] Optional "prefix" for default locale #18582

Closed
Vadorequest opened this issue Oct 31, 2020 · 7 comments
Closed

[I18n] Optional "prefix" for default locale #18582

Vadorequest opened this issue Oct 31, 2020 · 7 comments
Milestone

Comments

@Vadorequest
Copy link
Contributor

See #18419

I believe this discussion (#18419) could be converted into an issue. (and this issue could be closed)

@Timer Timer modified the milestone: 10.x.x Nov 1, 2020
@timneutkens
Copy link
Member

It was converted into a discussion on purpose. We'll convert them into implementation issues when relevant (e.g. this one currently has 15 upvotes, if there's more we can consider implementing it.)

@Timer Timer added this to the iteration 11 milestone Nov 2, 2020
@Vadorequest
Copy link
Contributor Author

Okay, I hadn't noticed it was created first as an issue.

@Vadorequest
Copy link
Contributor Author

@timneutkens FYI The discussion has reached around 30+ votes and a PR has been made by a new contributor, see #18419 (comment)

@Vadorequest
Copy link
Contributor Author

Vadorequest commented Jan 5, 2021

@timneutkens I see this issue is part of Iteration 11, does that means it has been treated, implemented or will be?

FYI The discussion has reached 75 upvotes. #18419

Additionally, it's a breaking change that is stopping me from migrating the Next Right Now boilerplate to the official implementation, despite being fully compatible otherwise, besides that breaking change. See UnlyEd/next-right-now#194

@samuelcastro
Copy link

@timneutkens Any update on this?

@samuelcastro
Copy link

@timneutkens Your feedback here will be much appreciated.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants