Turbopack: remove unused ModuleWithDirection from Node runtime (#79458)

AFAICT, this is only used in dev to correctly remove modules during HMR. But that is not the case for Node.js, where they are set but never used (and Node.js also only has a single runtime, no build vs dev split).

Author: mischnic

turbopack/crates/turbopack-ecmascript-runtime/js/src/nodejs/runtime.ts

@@ -62,7 +62,7 @@ const url = require('url') as typeof import('url')
 const fs = require('fs/promises') as typeof import('fs/promises')
 
 const moduleFactories: ModuleFactories = Object.create(null)
-const moduleCache: ModuleCache<ModuleWithDirection> = Object.create(null)
+const moduleCache: ModuleCache<Module> = Object.create(null)
 
 /**
  * Returns an absolute path to the given module's id.
@@ -213,10 +213,7 @@ function getWorkerBlobURL(_chunks: ChunkPath[]): string {
   throw new Error('Worker blobs are not implemented yet for Node.js')
 }
 
-function instantiateModule(
-  id: ModuleId,
-  source: SourceInfo
-): ModuleWithDirection {
+function instantiateModule(id: ModuleId, source: SourceInfo): Module {
   const moduleFactory = moduleFactories[id]
   if (typeof moduleFactory !== 'function') {
     // This can happen if modules incorrectly handle HMR disposes/updates,
@@ -252,13 +249,11 @@ function instantiateModule(
       invariant(source, (source) => `Unknown source type: ${source?.type}`)
   }
 
-  const module: ModuleWithDirection = {
+  const module: Module = {
     exports: {},
     error: undefined,
     loaded: false,
     id,
-    parents,
-    children: [],
     namespaceObject: undefined,
   }
   moduleCache[id] = module
@@ -315,19 +310,11 @@ function instantiateModule(
 // @ts-ignore
 function getOrInstantiateModuleFromParent(
   id: ModuleId,
-  sourceModule: ModuleWithDirection
-): ModuleWithDirection {
+  sourceModule: Module
+): Module {
   const module = moduleCache[id]
 
-  if (sourceModule.children.indexOf(id) === -1) {
-    sourceModule.children.push(id)
-  }
-
   if (module) {
-    if (module.parents.indexOf(sourceModule.id) === -1) {
-      module.parents.push(sourceModule.id)
-    }
-
     return module
   }
 

turbopack/crates/turbopack-tests/tests/snapshot/runtime/default_build_runtime/output/[turbopack]_runtime.js

@@ -590,8 +590,6 @@ function instantiateModule(id, source) {
         error: undefined,
         loaded: false,
         id,
-        parents,
-        children: [],
         namespaceObject: undefined
     };
     moduleCache[id] = module1;
@@ -646,13 +644,7 @@ function instantiateModule(id, source) {
  */ // @ts-ignore
 function getOrInstantiateModuleFromParent(id, sourceModule) {
     const module1 = moduleCache[id];
-    if (sourceModule.children.indexOf(id) === -1) {
-        sourceModule.children.push(id);
-    }
     if (module1) {
-        if (module1.parents.indexOf(sourceModule.id) === -1) {
-            module1.parents.push(sourceModule.id);
-        }
         return module1;
     }
     return instantiateModule(id, {