Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme is out of date #920

Open
royfalk opened this issue Nov 27, 2024 · 7 comments
Open

Readme is out of date #920

royfalk opened this issue Nov 27, 2024 · 7 comments
Milestone

Comments

@royfalk
Copy link
Contributor

royfalk commented Nov 27, 2024

Looking at the readme after I reinstalled my OS, I discovered it is out of date.

Missing:

  1. The change to SDL 2. So libsdl2-dev instead of libsdk1.2-dev.
  2. Also needed ninja-build and libxmu-dev. Not sure if that's only for vscode.
@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Dec 7, 2024
@BenjamenMeyer
Copy link
Member

ninja-build is probably an option for CMake; probably not required.
libxmu-dev is probably required

@kheckwrecker
Copy link

The instructions for building on Windows is out of date as well. It requires Visual Studios 2022 now, and the PYTHONHOME environment variable needs to be unset before running the build.

@royfalk
Copy link
Contributor Author

royfalk commented Dec 24, 2024

The instructions for building on Windows is out of date as well. It requires Visual Studios 2022 now, and the PYTHONHOME environment variable needs to be unset before running the build.

Why don't you edit the file? If it's a permissions issue, I'm sure something can be arranged.

@BenjamenMeyer
Copy link
Member

The instructions for building on Windows is out of date as well. It requires Visual Studios 2022 now, and the PYTHONHOME environment variable needs to be unset before running the build.

I'd love to see more PRs from others. ;)

@kheckwrecker
Copy link

The instructions for building on Windows is out of date as well. It requires Visual Studios 2022 now, and the PYTHONHOME environment variable needs to be unset before running the build.

Why don't you edit the file? If it's a permissions issue, I'm sure something can be arranged.

Concepts like git, repositories, pull requests etc. are a completely foreign language to me. I have no idea how to do any of those things. I'm happy to write the updated instructions for compiling in Windows and sending it to someone else for uploading, but the idea of editing a file in master myself? Shudder...

@royfalk
Copy link
Contributor Author

royfalk commented Dec 24, 2024

I'm happy to write the updated instructions

That would be fine. Also, you can click on edit for the readme without branches and PRs.

@kheckwrecker
Copy link

Tried clicking on both Edit and Edit in Place, and both require a separate fork. So I wrote up the updated instructions for review and posting by someone who know what they're doing:

Compiling On Windows
Vega Strike is now compiling on Windows! If you want to compile it, try it out, and perhaps offer feedback, that would certainly be welcome.

To compile Vega Strike on Windows, start by installing either Visual Studio 2022 or just the Visual Studio 2022 Developer Tools. When selecting the Workloads and Components to install, include at least "C++ for Desktop" and a recent build of the Windows SDK. Probably Git and the GitHub for Windows extension also. Install the latest Visual Studio updates as well.

Once the Visual Studio Installer finishes, reboot your computer. Then, find Developer PowerShell for VS 2022 on the Start menu; alt-click it ("right-click"); and choose "Run as Administrator." Run Set-ExecutionPolicy RemoteSigned (or another suitable PowerShell Execution Policy of your choice). Type Y and press Enter to confirm. Exit PowerShell. Now reopen Developer PowerShell for VS 2022, this time without Admin privileges, and run script/bootstrap.ps1. Once that finishes, reboot your computer again. Finally, open Developer PowerShell for VS 2022 one more time. You will need to unset the PYTHONHOME environment variable by entering [Environment]::SetEnvironmentVariable("PYTHONHOME", "") in the PowerShell window.
Then run script/build.ps1 -Generator VS2022Win64.

Assuming all the above steps succeed, you are now ready to run Vega Strike. Note that vegasettings and config.json are not currently building on Windows, so you will need to edit vegastrike.config and config.json manually as needed. Also note: Windows installer is still pending.

Finally, note that the location of the .vegastrike folder has changed since v0.5.1r1. It will now be located here: C:\Users<YourUserName>\AppData\Local.vegastrike.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants