-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Shareable link to eg https://vega.github.io/editor #3188
Comments
I think it is a good feature request. I would say it is useful. This requires a synergy with the Vega-editor though and we should be sure that for the foreseeable future this keeps working. If we try to do this, we should aim for not introducing new hard dependencies, but a soft dependency is acceptable I think. Btw, I also often publish my Altair derived VL-specification as gist on GitHub and refer to this in the Vega-editor. Than the shareable-url is much shorter than the LZW compressed string. We've discussed before to have a uniform approach for export methods. I opened #3189 to keep track on this. I think your suggestion of |
I agree. Definitely requires buy in from them. Please leave a comment there in support of this so they know that altair folks are interested!
This works in many cases, but not for me, because then the data is public, and I need to keep it private. |
This is a neat idea @NickCrews. I opened an issue in VlConvert about the idea of using a Rust implementation of lz-string to perform the URL encoding: vega/vl-convert#103. VlConvert is what Altair already uses by default for svg and png image export, so we could potentially add editor URL support using the same optional dependency. |
nice @jonmmease ! That is one path forward. Ideally though, I would rather have everyone using a more standard compression algorithm so
See my prototype using brotli in the editor issue. |
Following some updates in the linked editor issue, I think I've changed my stance a bit. I think fixing the existing python port of lz-string and adding it to Altair makes sense. It will only be one small python file, and we can always add the brotli stuff later. If I fix the lz-string port to python, I see a few paths forward:
What would you prefer @mattijn ? |
Or wait, I guess we could just use vlconvert directly? Should I write a PR that does this? |
@NickCrews, yeah I was picturing that we would use VlConvert for this the way we currently use it for svg/png image export. I'm expecting to do a VlConvert release toward the end of next week and I'll ping you when it's available. It would be great if you wanted to work on an Altair PR to add the |
If you are already in there adding to_pdf(), I would love to avoid learning how to set up the dev environment, tests, etc. So go for it! I can help review if you tag me. |
I filed the main issue at vega/editor#1365 because I thought that was a better place for it, but just posting this here for visibility. Please chime in there with your thoughts!
The text was updated successfully, but these errors were encountered: