From 0c72435e09ab6263c48bb566c733deb11f927bd9 Mon Sep 17 00:00:00 2001 From: dangotbanned <125183946+dangotbanned@users.noreply.github.com> Date: Wed, 22 Jan 2025 12:30:07 +0000 Subject: [PATCH] feat(typing): Set `"polars"` as default in `Loader.from_backend` Without a default, I found that VSCode was always suggesting the **last** overload first (`"pyarrow"`) This is a bad suggestion, as it provides the *worst native* experience. The default now aligns with the backend providing the *best native* experience --- altair/datasets/_loader.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/altair/datasets/_loader.py b/altair/datasets/_loader.py index 0bb91aa1f..8417e2d6a 100644 --- a/altair/datasets/_loader.py +++ b/altair/datasets/_loader.py @@ -48,7 +48,7 @@ class Loader(Generic[IntoDataFrameT, IntoFrameT]): @overload @classmethod def from_backend( - cls, backend_name: Literal["polars"], / + cls, backend_name: Literal["polars"] = ..., / ) -> Loader[pl.DataFrame, pl.LazyFrame]: ... @overload @@ -64,7 +64,7 @@ def from_backend( ) -> Loader[pa.Table, pa.Table]: ... @classmethod - def from_backend(cls, backend_name: _Backend, /) -> Loader[Any, Any]: + def from_backend(cls, backend_name: _Backend = "polars", /) -> Loader[Any, Any]: """ Initialize a new loader, with the specified backend.