Skip to content

Commit 8898975

Browse files
committed
ci: retrigger
1 parent 9b6e1d0 commit 8898975

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

hindsight-api-slim/hindsight_api/engine/memory_engine.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3828,9 +3828,13 @@ async def delete_memory_unit(
38283828

38293829
if bank_id_for_consolidation:
38303830
try:
3831-
await self.submit_async_consolidation(bank_id=bank_id_for_consolidation, request_context=request_context)
3831+
await self.submit_async_consolidation(
3832+
bank_id=bank_id_for_consolidation, request_context=request_context
3833+
)
38323834
except Exception as e:
3833-
logger.warning(f"Failed to submit consolidation after memory deletion for bank {bank_id_for_consolidation}: {e}")
3835+
logger.warning(
3836+
f"Failed to submit consolidation after memory deletion for bank {bank_id_for_consolidation}: {e}"
3837+
)
38343838

38353839
return result
38363840

hindsight-api-slim/tests/test_retain.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1103,13 +1103,12 @@ async def test_document_upsert_behavior(memory, request_context):
11031103

11041104
assert len(v2_units) > 0, "Should create units for v2"
11051105

1106-
# Recall should return the updated information
1106+
# Recall should return the updated information (no fact_type filter — LLM may classify as world or experience)
11071107
result = await memory.recall_async(
11081108
bank_id=bank_id,
11091109
query="What is the project status?",
11101110
budget=Budget.MID,
11111111
max_tokens=1000,
1112-
fact_type=["world"],
11131112
request_context=request_context,
11141113
)
11151114

hindsight-api-slim/tests/test_worker.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -952,8 +952,8 @@ async def mock_executor(task_dict):
952952
assert executed[0] == task_dict
953953

954954
@pytest.mark.asyncio
955-
async def test_sync_backend_handles_errors(self):
956-
"""Test that SyncTaskBackend handles executor errors gracefully."""
955+
async def test_sync_backend_propagates_errors(self):
956+
"""Test that SyncTaskBackend propagates executor errors instead of swallowing them."""
957957

958958
async def failing_executor(task_dict):
959959
raise ValueError("Test error")
@@ -962,8 +962,9 @@ async def failing_executor(task_dict):
962962
backend.set_executor(failing_executor)
963963
await backend.initialize()
964964

965-
# Should not raise, error is logged
966-
await backend.submit_task({"type": "test"})
965+
# Should raise so callers can handle or surface the failure
966+
with pytest.raises(ValueError, match="Test error"):
967+
await backend.submit_task({"type": "test"})
967968

968969

969970
class TestDynamicTenantDiscovery:

0 commit comments

Comments
 (0)