sagemathgh-41062: remove deprecations in finite_rings

after

File: src/sage/rings/finite_rings/element_base.pyx ; PR: sagemath#32664 ; Closed
Date: 2023-03-19
File: src/sage/rings/finite_rings/finite_field_constructor.py ; PR:
sagemath#32664 ; Closed Date: 2023-03-19
File: src/sage/rings/finite_rings/finite_field_base.pyx ; PR: sagemath#32664 ;
Closed Date: 2023-03-19

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

URL: sagemath#41062
Reported by: Frédéric Chapoton
Reviewer(s):

Author: Release Manager

build/pkgs/configure/checksums.ini

@@ -1,3 +1,3 @@
 tarball=configure-VERSION.tar.gz
-sha1=22617a1a12a247801d8cbf658f7df9978034e1a9
-sha256=fae518a4a51179e16965cbc55eb40a9b6ee89db7d81b5f7d9d0466262611b8a1
+sha1=32d7acb01f87cb27d4eba3306415c989a503eead
+sha256=16cd4131bf29641c784a9feb738e9f06acdbd0cea1a4971c057da7fa4d2cbfc7

build/pkgs/configure/package-version.txt

@@ -1 +1 @@
-ad729a3fe96044ea67fc1f78ea2e0bf2706f29eb
+e2e3770e034620a429291b30e676022d3c19a7c7

src/sage/rings/finite_rings/element_base.pyx

@@ -24,30 +24,6 @@ from sage.rings.integer_ring import ZZ
 from sage.rings.integer import Integer
 
 
-def is_FiniteFieldElement(x):
-    """
-    Return ``True`` if ``x`` is a finite field element.
-
-    This function is deprecated.
-
-    EXAMPLES::
-
-        sage: from sage.rings.finite_rings.element_base import is_FiniteFieldElement
-        sage: is_FiniteFieldElement(1)
-        doctest:...: DeprecationWarning: the function is_FiniteFieldElement is deprecated; use isinstance(x, sage.structure.element.FieldElement) and x.parent().is_finite() instead
-        See https://github.com/sagemath/sage/issues/32664 for details.
-        False
-        sage: is_FiniteFieldElement(IntegerRing())
-        False
-        sage: is_FiniteFieldElement(GF(5)(2))
-        True
-    """
-    from sage.misc.superseded import deprecation
-    deprecation(32664, "the function is_FiniteFieldElement is deprecated; use isinstance(x, sage.structure.element.FieldElement) and x.parent().is_finite() instead")
-
-    from sage.rings.finite_rings.finite_field_base import FiniteField
-    return isinstance(x, Element) and isinstance(x.parent(), FiniteField)
-
 
 cdef class FiniteRingElement(CommutativeRingElement):
     def _nth_root_common(self, n, all, algorithm, cunningham):

src/sage/rings/finite_rings/finite_field_base.pyx

@@ -2224,30 +2224,3 @@ def unpickle_FiniteField_prm(_type, order, variable_name, kwargs):
 
 register_unpickle_override(
     'sage.rings.ring', 'unpickle_FiniteField_prm', unpickle_FiniteField_prm)
-
-
-def is_FiniteField(R):
-    r"""
-    Return whether the implementation of ``R`` has the interface provided by
-    the standard finite field implementation.
-
-    This function is deprecated.
-
-    EXAMPLES::
-
-        sage: from sage.rings.finite_rings.finite_field_base import is_FiniteField
-        sage: is_FiniteField(GF(9,'a'))
-        doctest:...: DeprecationWarning: the function is_FiniteField is deprecated; use isinstance(x, sage.rings.finite_rings.finite_field_base.FiniteField) instead
-        See https://github.com/sagemath/sage/issues/32664 for details.
-        True
-        sage: is_FiniteField(GF(next_prime(10^10)))
-        True
-
-    Note that the integers modulo n are not backed by the finite field type::
-
-        sage: is_FiniteField(Integers(7))
-        False
-    """
-    from sage.misc.superseded import deprecation
-    deprecation(32664, "the function is_FiniteField is deprecated; use isinstance(x, sage.rings.finite_rings.finite_field_base.FiniteField) instead")
-    return isinstance(R, FiniteField)

src/sage/rings/finite_rings/finite_field_constructor.py

@@ -178,10 +178,6 @@
 from sage.rings.polynomial.polynomial_element import Polynomial
 from sage.rings.integer import Integer
 
-# the import below is just a redirection
-from sage.rings.finite_rings.finite_field_base import is_FiniteField
-assert is_FiniteField  # just to silent pyflakes
-
 try:
     # We don't late import this because this means trouble with the Givaro library
     # On a Macbook Pro OSX 10.5.8, this manifests as a Bus Error on exiting Sage.
@@ -839,34 +835,4 @@ def create_object(self, version, key, **kwds):
 GF = FiniteField = FiniteFieldFactory("FiniteField")
 
 
-def is_PrimeFiniteField(x):
-    """
-    Return ``True`` if ``x`` is a prime finite field.
-
-    This function is deprecated.
-
-    EXAMPLES::
-
-        sage: from sage.rings.finite_rings.finite_field_constructor import is_PrimeFiniteField
-        sage: is_PrimeFiniteField(QQ)
-        doctest:...: DeprecationWarning: the function is_PrimeFiniteField is deprecated; use isinstance(x, sage.rings.finite_rings.finite_field_base.FiniteField) and x.is_prime_field() instead
-        See https://github.com/sagemath/sage/issues/32664 for details.
-        False
-        sage: is_PrimeFiniteField(GF(7))
-        True
-        sage: is_PrimeFiniteField(GF(7^2, 'a'))
-        False
-        sage: is_PrimeFiniteField(GF(next_prime(10^90, proof=False)))
-        True
-    """
-    from sage.misc.superseded import deprecation
-    deprecation(32664, "the function is_PrimeFiniteField is deprecated; use isinstance(x, sage.rings.finite_rings.finite_field_base.FiniteField) and x.is_prime_field() instead")
-
-    from .finite_field_prime_modn import FiniteField_prime_modn
-    from sage.rings.finite_rings.finite_field_base import FiniteField as FiniteField_generic
-
-    return isinstance(x, FiniteField_prime_modn) or \
-           (isinstance(x, FiniteField_generic) and x.degree() == 1)
-
-
 zech_log_bound = 2**16