-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"requestFullscreen is not a function" in safari iOS #2
Comments
Hello mate, can you please describe your enivorment? did you use typescript or javascript? |
Sure, I'm using JS on react@16. I'm having something like this:
What I'm doing is using react-screen-orientation to be able to go fullscreen when phone is set in landscape. So signature pad gets full screen with 2 simple UI buttons. This works fine in Chrome and Firefox, but for Safari iOS seems to not be able to recognize the requestFullscreen call, and ends with browser completely white (like a broken fullscreen(?) ). PS: what about adding a prop for custom class name? (As the className prop above gets overwritten by component.) |
Hi, this might help you debug, or same result? |
well I am not sure, seems that way, but maybe there is a specific way to do this in safari? maybe the web browser just can't do it |
As I've looked around is a known issue around iOS' Safari not supporting fullscreenAPI. "Solution" so far for me is to disable feature for mobile Safari. Total bummer. Still this issue exists as it tries to use it and breaks with that message above. |
well if you have a suggestion how to prevent it from running on the problematic platform please make a pull request and I will update the module shortly. |
@vasilevich this is the error: https://github.com/vasilevich/react-fullscreen-crossbrowser/blob/master/src/index.tsx#L113 I'm currently busy and don't have time to code/test/PR it now, but I think fixing so ^ should be enough. |
Hi friend, I will gladly add what you asked but I am sorry I have no way of testing it, I don't have any IOS devices available. |
I'll be happy to test it when you have it on a branch. |
Sorry for posting after many years. I thought this would be very useful for those that crashed into ios/safari issues: |
@pleytonsoftware how did you solve this for using this react-fullscreen-crossbrowser package? |
Trying to get fullscreen display goes white and UI blocked, so there's no way to restore it but reloading page.
The text was updated successfully, but these errors were encountered: