Skip to content

Commit e9c1dd0

Browse files
committed
Reenable windows target for CI builds
1 parent 20df58c commit e9c1dd0

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,16 @@ jobs:
2727
runs-on: ${{ matrix.runs-on }}
2828
strategy:
2929
matrix:
30-
os: [ linux-intel, linux-arm, macos-arm ]
30+
os: [ linux-intel, linux-arm, macos-arm, windows ]
3131
include:
3232
- archs: auto64
3333
platform: auto
3434
- os: linux-intel
3535
runs-on: ubuntu-latest
3636
- os: linux-arm
3737
runs-on: ubuntu-24.04-arm
38-
# - os: windows
39-
# runs-on: windows-latest
38+
- os: windows
39+
runs-on: windows-latest
4040
- os: macos-arm
4141
# macos-14+ (including latest) are ARM64 runners
4242
runs-on: macos-latest

CMakeLists.txt

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,16 @@ execute_process(
1919
find_package(nanobind CONFIG REQUIRED)
2020

2121
# Find jaxlib include dir
22-
execute_process(
23-
COMMAND /usr/bin/env python3 -c "import inspect; import jaxlib; import pathlib; p = pathlib.Path(inspect.getfile(jaxlib)); print(p.parent / 'include')"
24-
OUTPUT_STRIP_TRAILING_WHITESPACE OUTPUT_VARIABLE jaxlib_INCLUDE_DIR)
22+
IF (WIN32)
23+
execute_process(
24+
COMMAND python -c "import inspect; import jaxlib; import pathlib; p = pathlib.Path(inspect.getfile(jaxlib)); print(p.parent / 'include')"
25+
OUTPUT_STRIP_TRAILING_WHITESPACE OUTPUT_VARIABLE jaxlib_INCLUDE_DIR)
26+
ELSE()
27+
execute_process(
28+
COMMAND /usr/bin/env python3 -c "import inspect; import jaxlib; import pathlib; p = pathlib.Path(inspect.getfile(jaxlib)); print(p.parent / 'include')"
29+
OUTPUT_STRIP_TRAILING_WHITESPACE OUTPUT_VARIABLE jaxlib_INCLUDE_DIR)
30+
ENDIF()
31+
2532

2633
# We are now ready to compile the actual extension module
2734
nanobind_add_module(

0 commit comments

Comments
 (0)