Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make watching base branch changes and waiting for idle jenkins job optional #51

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vood
Copy link

@vood vood commented Jan 16, 2014

Make watching base branch changes optional
Make waiting for idle jenkins job optional

@@ -33,6 +33,9 @@
# This makes sure we don't end up spamming GitHub's servers.
:github_polling_interval_seconds: 60

# By default Jently reschedules open pull request if base branch has been updated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may need a bit more explanation as I'm not sure how many people are familiar with the term 'base brach'

@vaneyckt
Copy link
Owner

Thank you for this. This looks really nice 👍 I just left a few (pedantic) comments on some small style issues

@jesseadams
Copy link
Contributor

👍 @vood are you going to get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants