Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO-15924 validation #2214

Open
xDivisionByZerox opened this issue Apr 10, 2023 · 5 comments · May be fixed by #2215
Open

Add ISO-15924 validation #2214

xDivisionByZerox opened this issue Apr 10, 2023 · 5 comments · May be fixed by #2215

Comments

@xDivisionByZerox
Copy link

Description

Hello, I'm a core member of the @faker-js/faker library.
We already use many of your validation methods to verify the integrity of our generated fake values.

For our newest addition, we want to verify codes for the representation of the names of scripts. Those are standardized by ISO-15924.

Suggested Validation

Validator name: isISO15924(str)
Validator Description: Check whether or not the string is a valid 4 character, ISO-15924 script code.

Additional Information

I'm willing to open a PR that integrate this feature if it get's approved.

@WikiRik
Copy link
Member

WikiRik commented Apr 10, 2023

Go for it! Looking forward to the PR

@xDivisionByZerox
Copy link
Author

Wow, that was fast.
Thank you.

@xDivisionByZerox xDivisionByZerox linked a pull request Apr 11, 2023 that will close this issue
4 tasks
@xDivisionByZerox
Copy link
Author

Hi @WikiRik, this Issue and the related PR are open for more than 8 months now. Is there anything I can do to help this moving forward? No pressure from my side, but I want to now what is going on 😄

@WikiRik
Copy link
Member

WikiRik commented Mar 1, 2024

I seemed to have missed the PR being opened, I will take a look at it. I do not have the rights to get it merged or anything so I can't really speed up that process. See also the recent discussion here; #2376

@xDivisionByZerox
Copy link
Author

Thank you for picking this one up. Again, there is no pressure from my side. I simply did a quick review on all my open PRs/Issues and tried to move them forward.

I was not aware of the situation of this project. I'll see if I can take part in the discussion, as my team and I use this library quite often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants