[WIP-DON'T MERGE YET] update pattern deletion logic #3557
dminnear-rhlint.yaml
on: pull_request
Run golangci-lint on PR
1m 33s
Annotations
8 errors
|
Run golangci-lint on PR
issues found
|
|
Run golangci-lint on PR:
internal/controller/acm.go#L71
func (*PatternReconciler).listManagedClusters is unused (unused)
|
|
Run golangci-lint on PR:
internal/controller/pattern_controller.go#L843
unused-parameter: parameter 'p' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Run golangci-lint on PR:
internal/controller/pattern_controller.go#L906
net/http.NewRequest must not be called. use net/http.NewRequestWithContext (noctx)
|
|
Run golangci-lint on PR:
internal/controller/pattern_controller.go#L921
G402: TLS InsecureSkipVerify set true. (gosec)
|
|
Run golangci-lint on PR:
internal/controller/pattern_controller.go#L858
G101: Potential hardcoded credentials (gosec)
|
|
Run golangci-lint on PR:
internal/controller/pattern_controller.go#L918
importShadow: shadow of imported from 'sigs.k8s.io/controller-runtime/pkg/client' package 'client' (gocritic)
|
|
Run golangci-lint on PR:
internal/controller/pattern_controller.go#L562
rangeValCopy: each iteration copies 992 bytes (consider pointers or indexing) (gocritic)
|