Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with Bun 1.2 #696

Open
Plopix opened this issue Jan 24, 2025 · 4 comments
Open

Compatibility issue with Bun 1.2 #696

Plopix opened this issue Jan 24, 2025 · 4 comments

Comments

@Plopix
Copy link

Plopix commented Jan 24, 2025

113 |         }
114 |         stdin.setEncoding('utf8');
115 |         if (isEnabled) {
116 |             // Ensure raw mode is enabled only once
117 |             if (this.rawModeEnabledCount === 0) {
118 |                 stdin.ref();
                            ^
TypeError: stdin.ref is not a function. (In 'stdin.ref()', 'stdin.ref' is undefined)
      at handleSetRawMode (node_modules/ink/build/components/App.js:118:23)```

when I switched to Bun 1.1.45 it works
@freeatnet
Copy link

Seems related to oven-sh/bun#16718

@ctjlewis
Copy link

ctjlewis commented Jan 27, 2025

This was fixed by oven-sh/bun#16767 in Bun. Not their bug.

@Plopix
Copy link
Author

Plopix commented Feb 7, 2025

not totally though now we have a panic error
I don't know if there is a work around we could do in this lib: oven-sh/bun#16821

@Plopix
Copy link
Author

Plopix commented Feb 10, 2025

I wonder if there would be a way somehow to close the useInput(), because the bug is appearing on the second use of useInput, like something was not closed/free correctly.

I don't have any details of the error, but I guess that somehow related to that. cc @vadimdemedes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants