-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 19 support #688
Comments
Same here |
Is someone using React internals? Hope they don't get fired. |
So the only thing left is to either downgrade React to version 18 or just wait? |
@KrisWis There's a temporary fork with a viable React 19 upgrade: https://github.com/QuentinFontenay/ink/tree/react-v19.0.0 |
But, the thing is, I don't use ink directly, I use Loki (for UI tests in conjunction with Storybook), and it in turn uses react-reconciler, which already uses ink. It's like this /: |
Based on the forked and updated Ink linked above (thank you @QuentinFontenay), I created this patch: https://gist.github.com/jakubmazanec/3b2b0c86bb7f34fe9ae0937d608b590b Use package
Overriding @sindresorhus I know you're probably very busy, but as a new maintainer (AFAIK), could you please give us some timeline when Ink will be fixed? Thank you. |
A pull request with the minimum amount of changes to add React 19 support is welcome. |
👍 |
+1 :-) |
Just to note, I tested this branch today - especially So sad ... |
As a hot fix, can we push a patch that prints a better error message in this corner case and link to this thread? For me, downgrading to react 18 wasn't a big deal but discovering this was a fix took a while. |
For those who depend on React 19 and Ink in the same package: NPM can install multiple versions of the same package into your "dependencies": {
"langium2": "npm:langium@^2.0.0",
"langium3": "npm:langium@^3.0.0"
} Here is how to call them: import { EmptyFileSystem as E2, createLangiumGrammarServices as G2 } from 'langium2';
import { EmptyFileSystem as E3 } from 'langium3';
import { createLangiumGrammarServices as G3 } from 'langium3/grammar';
console.log(G2(E2).grammar.Grammar.name);
console.log(G3(E3).grammar.Grammar.name); I will try out a scenario for Ink later this day using two React versions. I might update my post then... |
It seems that the current version of ink does not work with React 19. For example with some minimal code like this:
I get this output with react 18.3.1:
And this with react 19.0.0:
The text was updated successfully, but these errors were encountered: