Skip to content

Build fails with the latest release when built in debug mode #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
m4heshd opened this issue Apr 27, 2022 · 4 comments
Closed

Build fails with the latest release when built in debug mode #74

m4heshd opened this issue Apr 27, 2022 · 4 comments

Comments

@m4heshd
Copy link
Contributor

m4heshd commented Apr 27, 2022

The build fails with the following error:

sqlite3.c:273888:31: error: ‘mcVfsGlobal’ undeclared (first use in this function); did you mean ‘mcVfsSleep’?
   assert(p->pMainNext == 0 && mcVfsGlobal.pMain != p);

You can take a look at this run to inspect the error in depth.

utelle added a commit that referenced this issue Apr 27, 2022

Verified

This commit was signed with the committer’s verified signature.
rahmatnazali Rahmat Nazali Salimi
@utelle
Copy link
Owner

utelle commented Apr 27, 2022

Sorry, I simply forgot to replace the reference to mcVfsGlobal in the assert statement with the new structure.

Strange enough Visual C++ compiles the code in debug mode without any error or warning message.
Commit 91c7cd6 should fix the problem.

@m4heshd
Copy link
Contributor Author

m4heshd commented Apr 27, 2022

Perfect. Thank you so much for the very fast patch. I'm gonna wait for a release to run a test on bs3mc. I'll leave the issue open till the next release in case somebody else run into this issue. 😊

@utelle
Copy link
Owner

utelle commented Apr 27, 2022

I just made a new release. Sorry for the inconveniences.

@utelle utelle closed this as completed Apr 27, 2022
@m4heshd
Copy link
Contributor Author

m4heshd commented Apr 27, 2022

Sorry for the inconveniences.

That was no trouble at all.

All tests ran perfectly. Thank you again. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants