test stored_logs #138
Merged
test stored_logs #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrr
force-pushed
the
testable-stored-logs
branch
4 times, most recently
from
46f99de to
5929f6d
Compare
jrr
force-pushed
the
testable-stored-logs
branch
3 times, most recently
from
7a298bc to
75e0c96
Compare
jrr
force-pushed
the
testable-stored-logs
branch
6 times, most recently
from
b4d1d91 to
1ee5fa0
Compare
jrr
force-pushed
the
testable-stored-logs
branch
4 times, most recently
from
2ec3373 to
d1b0d1c
Compare
jrr
force-pushed
the
testable-stored-logs
branch
2 times, most recently
from
b467394 to
d88a3cd
Compare
Merged
this way the wrapper layer is not involved with the lifecycle of the underlying Preferences object
jrr
force-pushed
the
testable-stored-logs
branch
from
d88a3cd to
d75c7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradually working toward #133, this PR moves
stored_logs.cppto the library and adds a few unit tests.I wrapped the preferences access behind a new Persistence interface, so that unit tests can use a mock in-memory alternative. For now it's only used for stored_logs, but in the future it could be used to help make other areas of the app testable.