refactor: isolate onboarding core state bridge

Author: binarylogic

internal/app/onboarding/core_state_bridge.go

@@ -0,0 +1,37 @@
+package onboarding
+
+import (
+	"github.com/usetero/cli/internal/core/bootstrap"
+	"github.com/usetero/cli/internal/domain"
+)
+
+func (m *Model) toCoreState() bootstrap.State {
+	return bootstrap.State{
+		User:      m.state.user,
+		Org:       m.state.org,
+		Account:   m.state.account,
+		Workspace: m.state.workspace,
+		DDSite:    m.state.ddSite,
+		DDAPIKey:  m.state.ddAPIKey,
+		DDAccount: m.state.ddAccount,
+	}
+}
+
+func (m *Model) applyCoreState(state bootstrap.State) {
+	m.state.user = state.User
+	m.state.org = state.Org
+	m.state.account = state.Account
+	m.state.workspace = state.Workspace
+	m.state.ddSite = state.DDSite
+	m.state.ddAPIKey = state.DDAPIKey
+	m.state.ddAccount = state.DDAccount
+	m.syncServicesToState()
+}
+
+func (m *Model) syncServicesToState() {
+	accountID := domain.AccountID("")
+	if m.state.account != nil {
+		accountID = m.state.account.ID
+	}
+	m.services = m.services.WithAccountID(accountID)
+}

internal/app/onboarding/transition_handlers.go

@@ -7,40 +7,8 @@ import (
 
 	"github.com/usetero/cli/internal/app/onboarding/msgs"
 	"github.com/usetero/cli/internal/core/bootstrap"
-	"github.com/usetero/cli/internal/domain"
 )
 
-func (m *Model) toCoreState() bootstrap.State {
-	return bootstrap.State{
-		User:      m.state.user,
-		Org:       m.state.org,
-		Account:   m.state.account,
-		Workspace: m.state.workspace,
-		DDSite:    m.state.ddSite,
-		DDAPIKey:  m.state.ddAPIKey,
-		DDAccount: m.state.ddAccount,
-	}
-}
-
-func (m *Model) applyCoreState(state bootstrap.State) {
-	m.state.user = state.User
-	m.state.org = state.Org
-	m.state.account = state.Account
-	m.state.workspace = state.Workspace
-	m.state.ddSite = state.DDSite
-	m.state.ddAPIKey = state.DDAPIKey
-	m.state.ddAccount = state.DDAccount
-	m.syncServicesToState()
-}
-
-func (m *Model) syncServicesToState() {
-	accountID := domain.AccountID("")
-	if m.state.account != nil {
-		accountID = m.state.account.ID
-	}
-	m.services = m.services.WithAccountID(accountID)
-}
-
 func (m *Model) handlePreflightResolved(msg msgs.PreflightResolved) TransitionOutcome {
 	m.scope.Debug("preflight complete",
 		slog.String("outcome", string(msg.State.Outcome)),