fix: lint issues and update to golangci-lint v2 config

- Migrate .golangci.yml to v2 format with strict but pragmatic settings
- Fix unchecked type assertions in powersync/sync.go (could panic)
- Fix error comparisons to use errors.Is() (works with wrapped errors)
- Use http.MethodPost/Get and http.StatusUnauthorized constants
- Remove unused renderCentered function
- Update .envrc to default to local control plane
- Simplify Taskfile to use hermit-installed golangci-lint

Exclusions:
- internal/sqlite/: noctx (local DB, context not needed)
- pkg/client/: ST1003 naming (matches API naming)

Author: binarylogic

.envrc

@@ -3,14 +3,16 @@
 # Ensure hermit is loaded by the editor
 eval "$("$PWD/bin/hermit" env -)"
 
-# Tero CLI configuration
-# Uncomment to use local control plane (production is the default)
-# export TERO_API_ENDPOINT="http://localhost:8081/graphql"
+# Tero CLI configuration - Local control plane (default for development)
+export TERO_API_ENDPOINT="http://localhost:8081/graphql"
+export TERO_POWERSYNC_ENDPOINT="http://localhost:8084"
 
-# Use staging environment
-export TERO_API_ENDPOINT="https://api.usetero.dev/graphql"
+# WorkOS client ID (same for local dev)
 export TERO_WORKOS_CLIENT_ID="client_01JQCC2CJMTB8AY2JRMZXFY9R1"
-export TERO_POWERSYNC_ENDPOINT="https://powersync.usetero.dev"
+
+# Staging environment (uncomment to use instead of local)
+# export TERO_API_ENDPOINT="https://api.usetero.dev/graphql"
+# export TERO_POWERSYNC_ENDPOINT="https://powersync.usetero.dev"
 
 # Development: Skip to app mode after onboarding complete
 # Set to "true" to automatically transition from onboarding complete screen to app

.golangci.yml

@@ -1,6 +1,6 @@
 ---
-# GolangCI-Lint configuration for Tero CLI
-# Focuses on catching real issues while avoiding noise
+# GolangCI-Lint v2 configuration for Tero CLI
+# Strict but pragmatic - catches real bugs, ignores noise
 
 version: "2"
 
@@ -9,6 +9,7 @@ run:
   tests: true
 
 linters:
+  default: none
   enable:
     # Core static analysis (essential)
     - errcheck # Unchecked errors
@@ -17,7 +18,7 @@ linters:
     - unused # Unused code
     - ineffassign # Ineffectual assignments
 
-    # Code quality and style
+    # Code quality
     - misspell # Common misspellings
     - unconvert # Unnecessary type conversions
     - wastedassign # Wasted assignments
@@ -26,62 +27,63 @@ linters:
     - bodyclose # HTTP response body not closed
     - noctx # HTTP requests without context
     - rowserrcheck # SQL rows.Err() not checked
-    - copyloopvar # Loop variable copying (Go 1.22+)
+    - copyloopvar # Loop variable copying
 
     # Error handling
-    - errorlint # Error wrapping issues
+    - errorlint # Error wrapping issues (use errors.Is)
     - errname # Error naming conventions
 
-    # Interface and type safety
-    - forcetypeassert # Type assertion checking
-
-    # Additional valuable checks
-    - nilerr # Finds code that returns nil even if it checks that error is not nil
-    - nolintlint # Reports ill-formed or insufficient nolint directives
-    - usestdlibvars # Detects possibility to use variables/constants from stdlib
-
-linters-settings:
-  errcheck:
-    # Don't require error checks for these functions where it's reasonable to ignore
-    exclude-functions:
-      - (io.Closer).Close
-      - (*os.File).Close
-
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment # Can be noisy and performance impact is usually minimal
-      - shadow # Can be overly strict
-
-  staticcheck:
-    checks: ["all"]
-
-  nolintlint:
-    # Require explanation for nolint directives
-    require-explanation: true
-    # Require specific linter names in nolint directives
-    require-specific: true
-
-issues:
-  max-issues-per-linter: 0
-  max-same-issues: 0
-
-  exclude-rules:
-    # Allow security issues in test files
-    - path: '.*_test\.go$'
-      linters: [gosec]
-
-    # Allow unchecked type assertions in test files
-    - path: '.*_test\.go$'
-      linters: [forcetypeassert]
-
-    # Skip generated files entirely
-    - path: 'pkg/client/generated\.go$'
-      linters: [all]
-
-    # Allow unused parameters in interfaces
-    - text: "`(ctx|logger)` is unused"
-      linters: [unused]
+    # Type safety
+    - forcetypeassert # Unchecked type assertions can panic
+
+    # Additional checks
+    - nilerr # Returns nil even when error is not nil
+    - nolintlint # Validates nolint directives
+    - usestdlibvars # Use stdlib constants
+
+  settings:
+    govet:
+      enable-all: true
+      disable:
+        - fieldalignment # Noisy, minimal impact
+        - shadow # Overly strict
+
+    staticcheck:
+      checks: ["all"]
+
+    nolintlint:
+      require-explanation: true
+      require-specific: true
+
+  exclusions:
+    # Presets for common false positives
+    presets:
+      - comments
+      - std-error-handling
+
+    rules:
+      # Skip generated files
+      - path: 'pkg/client/generated\.go$'
+        linters: [all]
+
+      # Client wrappers match API naming (ApiKey not APIKey)
+      - path: "pkg/client/"
+        text: "ST1003"
+        linters: [staticcheck]
+
+      # API test mocks match the client interface naming
+      - path: "internal/api/apitest/"
+        text: "ST1003"
+        linters: [staticcheck]
+
+      # sqlite package: local DB, context cancellation not critical
+      # The interface intentionally omits context for simplicity
+      - path: "internal/sqlite/"
+        linters: [noctx]
+
+      # Allow unused ctx/logger parameters in interface implementations
+      - text: "`(ctx|logger)` is unused"
+        linters: [unused]
 
 severity:
   default: error

Taskfile.yml

@@ -97,12 +97,7 @@ tasks:
   lint:go:
     desc: Run golangci-lint
     cmds:
-      - |
-        if ! command -v golangci-lint &> /dev/null; then
-          echo "golangci-lint not found. Installing..."
-          go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
-        fi
-      - $(go env GOPATH)/bin/golangci-lint run ./...
+      - golangci-lint run ./...
 
   lint:scripts:
     desc: Lint shell scripts with shellcheck

internal/powersync/schema.go

@@ -103,7 +103,7 @@ func FetchSchemaJSON(ctx context.Context, endpoint, token string) (string, error
 
 // fetchColumnTypes fetches column type information from the schema API.
 func fetchColumnTypes(ctx context.Context, endpoint, token string) (map[string]map[string]columnType, error) {
-	req, err := http.NewRequestWithContext(ctx, "POST", endpoint+"/api/admin/v1/schema", strings.NewReader("{}"))
+	req, err := http.NewRequestWithContext(ctx, http.MethodPost, endpoint+"/api/admin/v1/schema", strings.NewReader("{}"))
 	if err != nil {
 		return nil, err
 	}
@@ -149,7 +149,7 @@ func fetchColumnTypes(ctx context.Context, endpoint, token string) (map[string]m
 
 // fetchSyncedTables fetches the synced tables from the sync rules API.
 func fetchSyncedTables(ctx context.Context, endpoint, token string, columnTypes map[string]map[string]columnType) ([]SchemaTable, error) {
-	req, err := http.NewRequestWithContext(ctx, "GET", endpoint+"/api/sync-rules/v1/current", nil)
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint+"/api/sync-rules/v1/current", nil)
 	if err != nil {
 		return nil, err
 	}