Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path for rsync 3 #2

Open
beetlefrosch opened this issue Apr 20, 2020 · 7 comments
Open

Path for rsync 3 #2

beetlefrosch opened this issue Apr 20, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested wip Work in progress
Milestone

Comments

@beetlefrosch
Copy link

My rsync version 3 is in /usr/local/bin/

How can I make grscyncx use this version?

@username0x0a
Copy link
Owner

username0x0a commented Apr 20, 2020

Is that a homebrew version? 🤔 The app currently works on top of the system-provided rsync via the fixed /usr/bin/rsync path as that one is included with all macOS installations. Is there any benefit of using v3? I'm not aware of possible differences in attributes support, that might be a bit of an issue when thinking about it.

@beetlefrosch
Copy link
Author

Yes, it's the homebrew version. I absolutely need the parameter --iconv!

@username0x0a
Copy link
Owner

Custom command path would be a nice addition then, putting it to the roadmap. 👍

@beetlefrosch
Copy link
Author

Custom command path would be a nice addition then, putting it to the roadmap. 👍

Very good! Very good. Thank you.

@tobsen
Copy link

tobsen commented Jul 24, 2020

Is there any benefit of using v3?

Yes, first of all it is a lot faster and I think there are some changes of the handling of macOS filesystem specials.
As far as I know, Apple won't ship 3, because of the license change.

@username0x0a
Copy link
Owner

username0x0a commented Jul 31, 2020

In version 0.2, custom rsync path can be used by setting a RSyncCommandPath key in app's defaults. 👍

Last time I checked rsync 3 from Homebrew it failed to synchronise Finder tags properly so if you have any tips on how to fix this use case with that version, feel free to poke me with more info.

@username0x0a username0x0a self-assigned this Aug 27, 2020
@username0x0a username0x0a added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Aug 27, 2020
@username0x0a username0x0a added this to the 1.0 milestone Aug 27, 2020
@username0x0a username0x0a added the wip Work in progress label Aug 27, 2020
@username0x0a
Copy link
Owner

There were probably many different changes between v2 and v3 (arguments in the first place) which need to be researched; further support for rsync 3 will probably take some time as it might need some UI alterations? I'm not sure about the impact size.

Until then however, you can use the RSyncCommandPath default setting mentioned above and put in custom arguments in the Advanced tab of the app. 👍 I've just tested it, -X was my greatest concern to make Finder tags working with v3.

If you use rsync 3 more often – shall you provide me with a raw mapping of options between versions 2 ↔ 3 & some further feedback, it would definitely help. 🙌

@beetlefrosch @tobsen

@username0x0a username0x0a pinned this issue Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested wip Work in progress
Projects
None yet
Development

No branches or pull requests

3 participants