Skip to content

Commit cc6e84c

Browse files
docs: note jj fallback in repo inference review convention (#327)
REVIEW.md told reviewers that new commands accepting a `repo` positional should fall back to inferring `owner/repo` from the git remote. After jj support was added to `src/utils/vcs.rs`, this convention is stale — a contributor following it would omit the jj fallback and write code inconsistent with the new pattern (and with the "git or jj remote (origin)" help text now advertised by `detail bugs`/`detail rules`/`detail scans`). Updated to mention jj and point at `src/utils/vcs.rs` for the canonical implementation. Introduced by commit 9b815d7 (@dbt, #324) --- _Doc Drift PRs can be [configured here](https://app.detail.dev/org_5f375fe3-a706-4e9a-a6f7-800f2439b3f6/settings/repos/repo_19fdc91f-383d-43df-bc6e-5c7996451fa2/doc-drift)._ <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/usedetail/cli/pull/327" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open in Devin Review"> </picture> </a> <!-- devin-review-badge-end --> <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Update REVIEW.md to state that repo inference should fall back to the git or jj remote and point to `src/utils/vcs.rs` for the canonical logic. Aligns review guidance with CLI help for `detail bugs`, `detail rules`, and `detail scans`. <sup>Written for commit 6e5fac9. Summary will update on new commits.</sup> <a href="https://cubic.dev/pr/usedetail/cli/pull/327?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> Co-authored-by: detail-app[bot] <180357370+detail-app[bot]@users.noreply.github.com>
1 parent 34b628c commit cc6e84c

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎REVIEW.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ Conventions that require human judgment during review. Lint-enforced rules
1515
- `--format json` must produce valid JSON. Never mix human-readable text (hints,
1616
update notices) into JSON output — guard behind a format check.
1717
- New commands that accept a `repo` positional should make it optional and fall
18-
back to inferring `owner/repo` from the git remote.
18+
back to inferring `owner/repo` from the git or jj remote (see
19+
`src/utils/vcs.rs`).
1920

2021
## Generated code
2122

0 commit comments

Comments
 (0)