-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add i18n support #311
base: master
Are you sure you want to change the base?
Add i18n support #311
Conversation
* Create POTFILES * Mark strings for translation * Add build configuration for updating and compile translation files * Add initial pt_BR translation
* Properly include <fmt/format.h> * Format texts in abaddon.cpp * Update abaddon.pot * Update pt_BR.po
* Mark startup.cpp strings for translation * Refactor chatinputindicator.cpp i18n * Update POTFILES * Update abaddon.pot
* Update abaddon.pot * Update POTFILES * Update Brazilian Portuguese Translation
The above commits implement internationalisation into Abaddon. This feature will allow users to utilise the application in their native language. It'll also allow contributors to translate the project into other available languages. This closes #308. BehaviourThe approach used for internationalisation is using gettext to read translated strings of a .mo file, which is usually located at Changes in the project workflowWith this addition, code that has some kind of text being shown to the user will also have to consider i18n. The workflow is not complicated since most cumbersome parts (i.e updating and compiling translations) are done by CMake. Of course, some manual work is still needed, like adding the source file to POTFILES for fetching strings for translation and updating abaddon.pot file. Workflow
|
i like how this looks :^) |
Guys, Linux and Windows builds are working as expected. However. the MacOS build is failing because of a "reference not found" error. I kind of have some idea of what it can be, but I don't want to mess up the commit history with tests. Does anyone have an appropriate solution for this? What I've found
|
if the fix is hacky so be it. if you wanna play around with CI runs without messing up commit history u can just do it on another branch and squash it in when it works |
Sorry for taking so long to respond, life stuff. Ok, I'll begin writing code for the Mac port. I will also add i18n code to the add-stage patches |
* Fix html typos * Update Brazilian Portuguese Translation
* Add i18n to the stages functionality * Update the Brazilian Portuguese Translation
|
* Fixes text rendering artifacts due to non-utf8 text * Update abaddon.pot
* Update abaddon.pot * Update pt_BR.po
This is still a work in Progress. Some testing still have to be made before opening for merging