Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CTA Modal #318

Open
jechols opened this issue Jul 26, 2024 · 0 comments
Open

Remove CTA Modal #318

jechols opened this issue Jul 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jechols
Copy link
Member

jechols commented Jul 26, 2024

The "cta-modal" code is busted when trying to get CSS to pass through to the shadow DOM, and the JS being minified makes it all but impossible to fix ourselves. With the update to Bootstrap 5, this is a major problem in dark mode.

Given that <dialog> now has very wide browser support, it's probably time to just ditch the custom dialog and build something simpler using as much native HTML as is possible, and no component nonsense unless we build that from scratch so we can easily control it.

@jechols jechols added the bug Something isn't working label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant