Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Migrate to pydantic V2 #19

Open
alextremblay opened this issue Oct 18, 2023 · 2 comments
Open

[TODO] Migrate to pydantic V2 #19

alextremblay opened this issue Oct 18, 2023 · 2 comments

Comments

@alextremblay
Copy link
Contributor

involves porting our custom BaseSettings class to use pydantic-settings

also involves migrating all our BaseModel instances to the new V2 structure as per https://docs.pydantic.dev/2.0/migration/

@alextremblay
Copy link
Contributor Author

this one's gonna be a doozy:

copier==8.1.0 [requires: pydantic>=1.10.2,<2]
diffsync==1.8.0 [requires: pydantic>=1.7.4,<2.0.0,!=1.8.1,!=1.8]
uoft-core==0.0.post395+g23ebab2.d20231204 [requires: pydantic>=1.9,<2.0]

all of these need to be updated to support pydantic V2

@alextremblay
Copy link
Contributor Author

copier v9 depends on pydantic v2, so that's an easy fix.
uoft-core is gonna take a fair bit of work
the bigger issue is diffsync. diffsync still depends on pydantic v1. there's an unreleased diffsync v2 which depends on pydantic v2, but it's not out yet. we need to wait for this networktocode/diffsync#232 and then wait for nautobot-ssot==1.3.2 [requires: diffsync>=1.6.0,<2.0.0] to cut a new release depending on diffsync v2, and then we can upgrade to pydantic v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant