Skip to content

Commit

Permalink
fix(Accordion): id and aria-controls was wrong
Browse files Browse the repository at this point in the history
* fix(Accordion, Collapsible): use separate id for content

- aria-controls needs to point to the ID of AccordionContent, not that
  of AccordionToggle
- added contentId prop on AccordionItem context, update content/toggle
  components
- move v-bind on CollapsibleContent to end, allows custom ID passed from
  AccordionContent to override the rootContext one

* Revert "fix(Accordion, Collapsible): use separate id for content"

This reverts commit 90ffbc0.

* fix(Accordion): id and aria-controls was wrong

---------

Co-authored-by: zernonia <[email protected]>
  • Loading branch information
dougwollison and zernonia authored Feb 5, 2024
1 parent 7b3c606 commit 67c589d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion packages/radix-vue/src/Accordion/AccordionContent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ useForwardExpose()

<template>
<CollapsibleContent
:id="itemContext.triggerId"
role="region"
:open="itemContext.open.value"
:hidden="!itemContext.open.value"
Expand Down
1 change: 0 additions & 1 deletion packages/radix-vue/src/Accordion/AccordionTrigger.vue
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ function changeItem() {
data-radix-vue-collection-item
:as="props.as"
:as-child="props.asChild"
:aria-controls="itemContext.triggerId"
:aria-disabled="itemContext.disabled.value || undefined"
:aria-expanded="itemContext.open.value || false"
:data-disabled="itemContext.dataDisabled.value"
Expand Down

0 comments on commit 67c589d

Please sign in to comment.