Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ItemsRepeater): text selection on iOS #19737

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(ItemsRepeater): text selection on iOS #19737

wants to merge 7 commits into from

Conversation

ajpinedam
Copy link
Contributor

@ajpinedam ajpinedam commented Mar 25, 2025 •
edited
Loading

GitHub Issue (If applicable): closes #19682

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

On iOS, when selecting Text inside an ItemsRepeater, the OS is adding an internal view _UIContainerWindowPortalView that is later causing a crash.

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam self-assigned this Mar 25, 2025
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Mar 25, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19737/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19737/index.html

@github-actions github-actions bot added the platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform label Mar 25, 2025
@ajpinedam ajpinedam requested a review from Xiaoy312 March 25, 2025 20:27
@ajpinedam ajpinedam marked this pull request as ready for review March 25, 2025 20:28
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19737/index.html

@ajpinedam ajpinedam changed the title test: (ItemsRepeater) add manual test sample fix(ItemsRepeater): text selection on iOS Mar 25, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19737/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19737/index.html

@ajpinedam ajpinedam requested a review from dr1rrb March 26, 2025 18:23
@ajpinedam ajpinedam force-pushed the dev/ajpm/ios.numbebox.inside.repeater branch from 93de5b0 to 7dfa5e8 Compare March 27, 2025 00:27
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19737/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19737/index.html

@ajpinedam ajpinedam force-pushed the dev/ajpm/ios.numbebox.inside.repeater branch from 84bc46c to 99b95a6 Compare March 29, 2025 16:35
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19737/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 158955 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 158942 has failed on Uno.UI - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@dr1rrb dr1rrb Awaiting requested review from dr1rrb

Assignees

@ajpinedam ajpinedam

Labels
area/automation Categorizes an issue or PR as relevant to project automation platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] When focusing on a NumberBox inside an ItemsRepeater, a crash occurs randomly by high chance.
3 participants
@ajpinedam @unodevops @Xiaoy312