Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS][NavigationView] When menu is contracted icons are clipped on the right #261

Open
1 of 5 tasks
StewartPolsky opened this issue Jul 21, 2020 · 3 comments
Open
1 of 5 tasks
Assignees
Labels
kind/bug Something isn't working low-prio

Comments

@StewartPolsky
Copy link
Contributor

Current behavior

Mac menu contracted

Expected behavior

UWP menu contracted

How to reproduce it (as minimally and precisely as possible)

  1. Launch app
  2. Contract NavigationView
  3. Notice that icons are clipped on the right side

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • UWP
  • MacOS

Anything else we need to know?

@StewartPolsky StewartPolsky added the kind/bug Something isn't working label Jul 21, 2020
@carldebilly carldebilly self-assigned this Jul 21, 2020
@StewartPolsky StewartPolsky changed the title [Mac][NavigationView] When menu is contracted icons are clipped on the right [macOS][NavigationView] When menu is contracted icons are clipped on the right Jul 23, 2020
@dr1rrb dr1rrb assigned dr1rrb and unassigned carldebilly Jul 27, 2020
@dr1rrb
Copy link
Member

dr1rrb commented Jul 27, 2020

This issue is actually caused by a settings of the system

image

image

Investigating how we could handle this properly ...

@dr1rrb
Copy link
Member

dr1rrb commented Jul 27, 2020

So basically it means that when the display mode is "always" we should add the width of the scroll bar to the NavigationView.CompactPaneLenght. The issue is that this property is directly bound to the SplitView, so currenlty fixing this would mean either:

  • Authoritatively add the SB width in set (so NV.CompactPaneLenght = 100; Assert.IsTrue(NV.CompactPaneLenght == 100); would fail)
  • Break the compatibility with the UWP NavigationView's template by adding a special case.

Instead we will keep this as-is for now, and we will add support of the managed ScrollBar in the ScrollViewer for MacOS, which will give us greater control for the different display mode in that case.

@MatFillion
Copy link
Contributor

@dr1rrb we don't have compact view in Uno.Gallery so it's ok to leave as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working low-prio
Projects
None yet
Development

No branches or pull requests

4 participants