Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scanner)!: limit patterns scanned from modules/ dir #2681

Merged
merged 4 commits into from
Sep 28, 2024
Merged

fix(scanner)!: limit patterns scanned from modules/ dir #2681

merged 4 commits into from
Sep 28, 2024

Conversation

Barbapapazes
Copy link
Member

@Barbapapazes Barbapapazes commented Aug 22, 2024 •
edited
Loading

Hello 👋,

fix #2680 in order to limit files scanned as modules.

@Barbapapazes Barbapapazes changed the base branch from v2 to main August 22, 2024 14:27
@Barbapapazes Barbapapazes linked an issue Aug 22, 2024 that may be closed by this pull request
Nitro scanModules returns every files #2680
Open
@pi0
Copy link
Member

pi0 commented Aug 22, 2024 •
edited
Loading

Can you please rebase against v2? 🙏🏼 (also no new fixture is required)

@Barbapapazes Barbapapazes changed the base branch from main to v2 August 22, 2024 19:34
@Barbapapazes
Copy link
Member Author

Can you please rebase against v2? 🙏🏼 (also no new fixture is required)

Yes!

@pi0 pi0 changed the base branch from v2 to main September 28, 2024 06:57
@pi0 pi0 changed the title fix: limit files scanned by the modules scanner fix(scanner): limit patterns scanned from modules/ dir Sep 28, 2024
pi0
pi0 approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! rebased (back) to the main (v3) again since it is technically behavior breaking change.

@pi0 pi0 changed the title fix(scanner): limit patterns scanned from modules/ dir fix(scanner)!: limit patterns scanned from modules/ dir Sep 28, 2024
@pi0 pi0 merged commit 286c18c into nitrojs:main Sep 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nitro scanModules returns every files
2 participants
@Barbapapazes @pi0