This repository has been archived by the owner on May 26, 2021. It is now read-only.
Enhancement: AbstractUnit's final methods now guarantee to return AbstractUnit<> instead of just Unit<> #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrows the return type of final methods in AbstractUnit from Unit<> to AbstractUnit<>. The only behavioural change is that if a third-party Unit<> that doesn't extend AbstractUnit<> is passed to one of these methods for transformation, it will be wrapped in a ProductUnit even when that wasn't previously necessary. This may cause some tests that rely on reference equality to fail; but in a near-future PR, I'll fix this by refining the implementation of ProductUnit.equals().