Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit visibility for ProductUnit.getPowInstance (advised by Codacy) #6

Closed
keilw opened this issue Aug 19, 2017 · 4 comments
Closed
Labels
Milestone

Comments

@keilw
Copy link
Member

keilw commented Aug 19, 2017

See unitsofmeasurement/uom-se#180
Rest under #7

@keilw keilw added the task label Aug 19, 2017
@keilw keilw changed the title Apply relevant parts of uom-se PR #180 Explicit visibility for ProductUnit.getPowInstance (advised by Codacy) Aug 19, 2017
@Pr0methean
Copy link

This commit was designed purely to satisfy Codacy; feel free to suppress Codacy's warning about implicit package-local access if there's a good reason for the affected methods not to be public or protected.

@keilw
Copy link
Member Author

keilw commented Aug 23, 2017

Thanks, it is consistent with the other implementations, but here as you may have seen the static accessors were renamed to ofX() already. No strong need to do it in all other implementations, as one usually does not call them directly but via Unit.multiply() or similar. At the moment I'm hesitant to apply all the AbstractUnit changes here. Among possible goals for a new version of the JSR is unitsofmeasurement/unit-api#38 which hints that if somehow possible without incompatibilities or twists, we could make one implementation co-exist with others under the right circmumstances even in the same module or class path.

@keilw
Copy link
Member Author

keilw commented Aug 23, 2017

@Pr0methean You are more than welcome to join the JCP e.g. as Associate btw, if you consider helping Indriya and an upcoming new version of the JSR.

@Pr0methean
Copy link

Sounds great! I'll take a look at Indriya some time in the next few weeks.

@keilw keilw added the to do label Nov 30, 2017
@keilw keilw added this to the 2.0 milestone Dec 28, 2017
@keilw keilw removed the to do label Jan 22, 2018
@keilw keilw closed this as completed Mar 25, 2018
@keilw keilw removed the in progress label Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants