Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wait_timeout_ms/timeout_ms API fields to timeout_s #2071

Open
craciunoiuc opened this issue Jan 15, 2025 · 0 comments
Open

Update wait_timeout_ms/timeout_ms API fields to timeout_s #2071

craciunoiuc opened this issue Jan 15, 2025 · 0 comments
Assignees
@craciunoiuc
Labels
kind/enhancement New feature or request

Comments

@craciunoiuc
Copy link
Member

Feature request summary

This should actually happen in https://github.com/kraftcloud/go-sdk but we track it here for visibility

Fields have been updated to reduce granularity, but this is not upstream on all nodes. Once @marcrittinghaus upstreams it, it will become backwards compatible for a period of time, and that is when the update should happen.

The change will reduce granularity, and such all usages of Wait() and the others should be updated once the go-sdk bump happens.

Tracking here so we don't lose state

Describe alternatives

No response

Related architectures

None

Related platforms

None

Additional context

No response
@craciunoiuc craciunoiuc added the kind/enhancement New feature or request label Jan 15, 2025
@craciunoiuc craciunoiuc self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craciunoiuc craciunoiuc

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craciunoiuc