Skip to content

How to name string-match selector: :string, :select, :equals or something else? #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aphillips opened this issue Jul 23, 2023 · 3 comments · Fixed by #594
Closed

How to name string-match selector: :string, :select, :equals or something else? #433

aphillips opened this issue Jul 23, 2023 · 3 comments · Fixed by #594
Labels
Agenda+ Requested for upcoming teleconference blocker Blocks the release LDML45 LDML45 Release (Tech Preview) specification Issue affects the specification

Comments

@aphillips
Copy link
Member

See discussion in #425, #431 and elsewhere. We need to choose what annotation signifies the comparison selector.
@aphillips aphillips added blocker Blocks the release specification Issue affects the specification labels Jul 23, 2023
@aphillips aphillips mentioned this issue Jul 23, 2023
Merged
@aphillips aphillips mentioned this issue Aug 13, 2023
Closed
@aphillips aphillips mentioned this issue Aug 22, 2023
Merged
@aphillips aphillips mentioned this issue Dec 8, 2023
Merged
aphillips added a commit that referenced this issue Dec 8, 2023
@aphillips
(Design) Exact Match Selector Options
a286c85 
In response to #433 we need to choose a name for the "exact match" selector.

This isn't done yet but will serve as a foundation for choosing.
@aphillips aphillips mentioned this issue Dec 8, 2023
Merged
@aphillips
Copy link
Member Author

In the 2023-12-11 teleconference, the consensus was to use the name :string

@markusicu
Copy link
Member

"string" sounds ambiguous; if anything, more like a formatting function name. It would be better to pick a name that sounds related to matching/selecting.

aphillips added a commit that referenced this issue Dec 18, 2023
@aphillips @eemeli
(Design) Exact Match Selector Options (#557)
5d5a425 
* (Design) Exact Match Selector Options

In response to #433 we need to choose a name for the "exact match" selector.

This isn't done yet but will serve as a foundation for choosing.

* Update exact-match-selector-options.md

* Update exact-match-selector-options.md

* Update exact-match-selector-options.md

* Update exploration/exact-match-selector-options.md

* Update exploration/exact-match-selector-options.md

Co-authored-by: Eemeli Aro <[email protected]>

* Address comment

We require annotations, so the text was inappropriate in the "background" section. Fixed it to be consistent with our policy/syntax/etc.

* Change exact match selector design to "proposed"

---------

Co-authored-by: Eemeli Aro <[email protected]>
@aphillips aphillips added LDML45 LDML45 Release (Tech Preview) resolve-candidate This issue appears to have been answered or resolved, and may be closed soon. Agenda+ Requested for upcoming teleconference and removed resolve-candidate This issue appears to have been answered or resolved, and may be closed soon. labels Jan 8, 2024
@aphillips
Copy link
Member Author

There has been additional work on the design document and we discussed it in 2024-01-08's call, so updating this issue to reflect status.

@eemeli eemeli linked a pull request Jan 15, 2024 that will close this issue
Add :string as formatter and selector #594
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Agenda+ Requested for upcoming teleconference blocker Blocks the release LDML45 LDML45 Release (Tech Preview) specification Issue affects the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add :string as formatter and selector unicode-org/message-format-wg
2 participants
@aphillips @markusicu