Deprecate Date::new_from_iso/Date::to_iso
#7287
Merged
+626
−819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
date-api
branch
2 times, most recently
from
3e7b3b1 to
0887c4b
Compare
sffc
reviewed
Dec 6, 2025
robertbastian
force-pushed
the
date-api
branch
2 times, most recently
from
eecd247 to
940b36f
Compare
robertbastian
force-pushed
the
date-api
branch
from
940b36f to
ebbac20
Compare
robertbastian
force-pushed
the
date-api
branch
from
ebbac20 to
04d6906
Compare
sffc
reviewed
Dec 8, 2025
| let roc_from_case = Date::new_from_iso(iso_from_case, Roc); | ||
| assert_eq!(iso_from_rd, iso_from_case, | ||
| "ISO from RD not equal to ISO generated from manually-input ymd\nCase: {case:?}\nRD: {iso_from_rd:?}\nManual: {iso_from_case:?}"); | ||
| let roc_from_case = Date::try_new_roc( |
Member
There was a problem hiding this comment.
In this test, you removed the new_from_iso and now only create from the ROC dates and the RD.
Are we still satisfactorily covering the has_cheap_iso_conversion code path?
let inner = if c1.has_cheap_iso_conversion() && c2.has_cheap_iso_conversion() {
c2.from_iso(c1.to_iso(self.inner()))
} else {
// `from_rata_die` precondition is satified by `to_rata_die`
c2.from_rata_die(c1.to_rata_die(self.inner()))
};
Member
Author
There was a problem hiding this comment.
there are a couple of tests that exercise this code, it's shared between all AbstractGregorian calendars, so we don't necessarily need to test it on Roc
it might make sense to add a few test specifically for this code in date.rs.
robertbastian
force-pushed
the
date-api
branch
from
ef13d7c to
e2eae91
Compare
sffc
approved these changes
Dec 9, 2025
| fn test_to_calendar() { | ||
| let date = Date::try_new_gregorian(2025, 12, 9).unwrap(); | ||
| // These conversions use the AbstractGregorian fast path | ||
| let date2 = date.to_calendar(Buddhist).to_calendar(Gregorian); |
Member
There was a problem hiding this comment.
Suggestion: It seems better to test this for all calendars, not just Buddhist
Manishearth
approved these changes
Dec 9, 2025
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
Generally not a fan of churning the APIs here more but I guess it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should stop treating the ISO calendar as special. Conversions are available through
to_calendar()like for all other calendars, and there shouldn't be two ways of doing things.This also cleans up old code in
AnyCalendarthat converts through ISO, which skips the optimisations in.to_calendar().