-
Notifications
You must be signed in to change notification settings - Fork 413
CLDR-19034 Keep page names backwards compatible #5216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
-New PathHeader.PageId.fromStringCompatible maps old names to new, only used for http requests -New TestPathHeaderCompat.java confirms old names still work
|
This maybe completes the ticket. There is a preexisting problem, maybe outside the scope of this ticket: if you go to https://cldr-smoke.unicode.org/cldr-apps/v#/ab/AAA then instead of a friendly warning message like "No page named AAA was found" and a redirection to the default page for the locale, you get this:
Even worse, if you click the Reload button, the same thing happens again and again! The Reload button should not cause the same bad URL to be fetched repeatedly. Also, the log shows a long message each time, see below. Shall I make a more friendly response as part of this ticket? [INFO] [err] com.ibm.icu.util.ICUException: No PageId for AAA |

-New PathHeader.PageId.fromStringCompatible maps old names to new, only used for http requests
-New TestPathHeaderCompat.java confirms old names still work
CLDR-19034
ALLOW_MANY_COMMITS=true