Update deps #99
Open
Update deps #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* missing : tables, nested list styles, checklists
* faker v10 is not compatible with jest : https://v10.fakerjs.dev/guide/upgrading.html#incompatibility-with-jest
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+129
to
+131
| return html | ||
| .replaceAll('class=""', '') | ||
| .replaceAll(/(?<=<[^>]+)(?<!\w|")\s+(?=[^>]*>)|(?<=<[^>]*(?:\w|"))\s+(?=>)/g, ''); |
Check failure
Code scanning / CodeQL
Incomplete multi-character sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix this problem, we should ensure that all <script> tags, as well as other potentially dangerous HTML elements (e.g., <iframe>, <object>, <embed>, and attributes like onerror, onclick), are removed from the generated HTML string before returning it. The recommended standard is to use a well-known, vetted HTML sanitization library such as sanitize-html (npm package), which reliably strips dangerous content and attributes while retaining safe markup.
- Update the file
src/lexical/lexical.module.ts. - Import
sanitize-htmlat the top. - In
generateHTML, run the output HTML (html) throughsanitizeHtmlbefore further string replacements. - No changes to function arguments or existing logic, only add sanitization immediately after DOM generation and before existing post-processing.
- You need to add an import of
sanitize-html.
Suggested changeset
2
src/lexical/lexical.module.ts
| @@ -1,4 +1,5 @@ | ||
| import { Module } from '@nestjs/common'; | ||
| import sanitizeHtml from 'sanitize-html'; | ||
| import { TextNode, ParagraphNode } from 'lexical'; | ||
| import { createHeadlessEditor } from '@lexical/headless'; | ||
| import { $generateHtmlFromNodes } from '@lexical/html'; | ||
| @@ -126,6 +127,11 @@ | ||
| editor.setEditorState(editor.parseEditorState(parsed)); | ||
| editor.read(() => (html = $generateHtmlFromNodes(editor))); | ||
| }); | ||
| // sanitize the HTML against script injection and unsafe markup | ||
| html = sanitizeHtml(html, { | ||
| allowedTags: sanitizeHtml.defaults.allowedTags.filter(tag => tag !== 'script' && tag !== 'iframe' && tag !== 'object' && tag !== 'embed'), | ||
| allowedAttributes: false, // remove all attributes except safe defaults | ||
| }); | ||
| return html | ||
| .replaceAll('class=""', '') | ||
| .replaceAll(/(?<=<[^>]+)(?<!\w|")\s+(?=[^>]*>)|(?<=<[^>]*(?:\w|"))\s+(?=>)/g, ''); |
package.json
Outside changed files
| @@ -71,7 +71,8 @@ | ||
| "prisma": "^7.1.0", | ||
| "reflect-metadata": "^0.2.2", | ||
| "rxjs": "^7.8.2", | ||
| "sharp": "^0.34.5" | ||
| "sharp": "^0.34.5", | ||
| "sanitize-html": "^2.17.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@faker-js/faker": "^9.9.0", |
This fix introduces these dependencies
| Package | Version | Security advisories |
| sanitize-html (npm) | 2.17.0 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #99 +/- ##
==========================================
- Coverage 83.19% 79.29% -3.91%
==========================================
Files 140 119 -21
Lines 2398 2347 -51
Branches 470 387 -83
==========================================
- Hits 1995 1861 -134
+ Misses 398 372 -26
- Partials 5 114 +109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mise à jour des dépendances de l'api (basé sur
feat/lexical-generator)Faker v10 n'est pas compatible avec jest, il existe un workaround qui consiste à utiliser babel... Mais c'est un peu lourd pour les test, non ? Si on décide d'utiliser babel parce que jest ne supporte les packages pure-esm, on pourra réintroduire les tests unitaires de lexical (cf. #97)