Skip to content

Gevent monkey patching interferes with non-gevent testing #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OK-UNDP opened this issue Sep 7, 2019 · 0 comments
Closed

Gevent monkey patching interferes with non-gevent testing #6

OK-UNDP opened this issue Sep 7, 2019 · 0 comments
Assignees
@OK-UNDP
Labels
area:testing Improvements or additions to test coverage bug:normal Issue affecting majority of users level:easy Solution is easy to implement
Milestone
0.1.0-rc.2

Comments

@OK-UNDP
Copy link
Contributor

OK-UNDP commented Sep 7, 2019

Monkey patching is enabled in tests/conftest.py for benchmarking that involves gevent functionality. However, this causes non-gevent test to fail due to a recursion issue in requests library.

Test configuration should be split, so gevent monkey patching is applied only for tests requiring it.
@OK-UNDP OK-UNDP added area:testing Improvements or additions to test coverage bug:normal Issue affecting majority of users level:easy Solution is easy to implement labels Sep 7, 2019
@OK-UNDP OK-UNDP added this to the 0.1.0-rc.2 milestone Sep 7, 2019
@OK-UNDP OK-UNDP self-assigned this Sep 7, 2019
@OK-UNDP OK-UNDP closed this as completed in 7577a72 Sep 7, 2019
OK-UNDP added a commit that referenced this issue Sep 13, 2019
@OK-UNDP
Merge tag '0.1.0-rc.2' into develop
e9d5f03 
0.1.0-rc.2 (2019-09-12)

New

* Publish docs on RTD (fixes #5). [OK-UNDP]

  Provide `.readthedocs.yaml` for RTD build environment.

  Change `description` in `pyproject.toml` to single-line format to address python-poetry/poetry#1372

  Apply minor doc fixes.

  !wip

  !wip

Fix

* Gevent monkey patching (fixes #6). [OK-UNDP]

  Ensure `gevent` monkey patching is performed
  only for tests requiring it.

* Read-only docker image (fixes #4). [OK-UNDP]

  Ensure all PID files are placed in `/tmp`. Provide an example
  `docker-compose.yaml` demonstrating how to deploy workers as
  read-only images with `tmpfs` volume mounted to `/tmp`.

* Empty `app_config.yaml` (fixes #3). [OK-UNDP]

  Properly handle empty or comments-only `app_config.yaml`.

* MsGraphResponse iterator (fixes #2). [OK-UNDP]

  Refactoring that allows `MsGraphResponse` to be repeatedly iterated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OK-UNDP OK-UNDP

Labels
area:testing Improvements or additions to test coverage bug:normal Issue affecting majority of users level:easy Solution is easy to implement
Projects
None yet
Milestone
0.1.0-rc.2
Development

No branches or pull requests
1 participant
@OK-UNDP