feat: improve cli and more

Author: twlite

apps/test-bot/commandkit.config.ts

@@ -2,6 +2,6 @@ import { defineConfig } from 'commandkit';
 import { legacy } from '@commandkit/legacy';
 
 export default defineConfig({
-  plugins: [legacy()],
+  plugins: [legacy({ skipBuiltInValidations: true })],
   typedLocales: true,
 });

apps/test-bot/src/app/locales/en-US/legacy.json

@@ -0,0 +1,9 @@
+{
+  "command": {
+    "name": "legacy",
+    "description": "Pong!"
+  },
+  "translations": {
+    "greet": "Hello there from legacy command, {user}!"
+  }
+}

apps/test-bot/src/commands/legacy.ts

@@ -0,0 +1,15 @@
+import type { CommandData, SlashCommandProps } from '@commandkit/legacy';
+import { locale } from '@commandkit/legacy';
+
+export const data: CommandData = {
+  name: 'legacy',
+  description: 'Pong!',
+};
+
+export async function run({ interaction }: SlashCommandProps) {
+  const { t } = await locale<'legacy'>();
+
+  const message = await t('greet', { user: interaction.user.username });
+
+  await interaction.reply(message);
+}

apps/test-bot/src/commands/legacy-autocomplete.ts renamed to apps/test-bot/src/commands/old/legacy-autocomplete.ts

@@ -0,0 +1,5 @@
+import { Logger } from 'commandkit';
+
+export default function onReady() {
+  Logger.log('Ready from legacy event handler');
+}

apps/test-bot/src/commands/legacy-content.ts renamed to apps/test-bot/src/commands/old/legacy-content.ts

@@ -34,7 +34,7 @@ export let commandkit: CommandKit;
 
 export class CommandKit extends EventEmitter {
   #started = false;
-  public readonly eventInterceptor: EventInterceptor;
+  public eventInterceptor!: EventInterceptor;
 
   public static readonly createElement = createElement;
   public static readonly Fragment = Fragment;
@@ -60,7 +60,7 @@ export class CommandKit extends EventEmitter {
    * @param options - The default CommandKit configuration.
    * @see {@link https://commandkit.js.org/docs/guide/commandkit-setup}
    */
-  constructor(private options: CommandKitOptions) {
+  constructor(private readonly options: CommandKitOptions) {
     if (CommandKit.instance) {
       process.emitWarning(
         'CommandKit instance already exists. Having multiple instance in same project is discouraged and it may lead to unexpected behavior.',
@@ -86,7 +86,6 @@ export class CommandKit extends EventEmitter {
       options.cacheProvider = new MemoryCache();
     }
 
-    this.eventInterceptor = new EventInterceptor(options.client);
     this.plugins = new CommandKitPluginRuntime(this);
 
     if (!CommandKit.instance) {
@@ -104,6 +103,14 @@ export class CommandKit extends EventEmitter {
   async start(token?: string | false) {
     if (this.#started) return;
 
+    if (!this.options.client) {
+      throw new Error(
+        colors.red('"client" is required when starting CommandKit.'),
+      );
+    }
+
+    this.eventInterceptor = new EventInterceptor(this.client);
+
     if (COMMANDKIT_IS_DEV) {
       try {
         registerDevHooks(this);

apps/test-bot/src/commands/old/legacy.ts

@@ -156,6 +156,10 @@ export class Context<
     this.client = commandkit.client;
     this.#store = config.store ?? new Map();
     this.command = config.command;
+
+    if (this.config.environment) {
+      this.config.environment.setContext(this);
+    }
   }
 
   /**

apps/test-bot/src/events/ready/test.ts

@@ -73,7 +73,7 @@ export class DefaultLocalizationStrategy implements LocalizationStrategy {
     );
 
     const header = `// auto generated file do not edit\nexport {};\ndeclare module 'commandkit' {\n  export interface CommandLocalizationTypeData {\n`;
-    const footer = `  type TranslatableCommandName = keyof CommandLocalizationTypeData\n}\n}`;
+    const footer = `  }\ntype TranslatableCommandName = keyof CommandLocalizationTypeData\n}`;
 
     const generateType = (locale: Translation) => {
       // Create type definition for this command's translations