Skip to content

Commit f8a454d

Browse files
committed
feat(launch): pass REVDIFF_CONFIG to overlay and add configurable popup size
Two improvements to the launch script: 1. Pass REVDIFF_CONFIG env var as --config flag to revdiff inside tmux popups. The sh -c invocation doesn't inherit fish universal variables, so the config path was lost in overlay shells. 2. Add REVDIFF_POPUP_WIDTH and REVDIFF_POPUP_HEIGHT env vars to override the default 90% tmux popup dimensions.
1 parent 7f403ca commit f8a454d

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

.claude-plugin/skills/revdiff/scripts/launch-revdiff.sh

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@ fi
1717
OUTPUT_FILE=$(mktemp /tmp/revdiff-output-XXXXXX)
1818
trap 'rm -f "$OUTPUT_FILE"' EXIT
1919

20-
REVDIFF_CMD="$REVDIFF_BIN --output=$OUTPUT_FILE $*"
20+
CONFIG_FLAG=""
21+
if [ -n "${REVDIFF_CONFIG:-}" ] && [ -f "$REVDIFF_CONFIG" ]; then
22+
CONFIG_FLAG="--config=$REVDIFF_CONFIG"
23+
fi
24+
REVDIFF_CMD="$REVDIFF_BIN $CONFIG_FLAG --output=$OUTPUT_FILE $*"
2125
CWD="$(pwd)"
2226

2327
# build descriptive title: "rd: dirname [ref]"
@@ -35,9 +39,13 @@ for arg in "$@"; do
3539
done
3640
OVERLAY_TITLE="rd: ${DIR_NAME}${TITLE_REF:+ [$TITLE_REF]}"
3741

42+
# overlay size: override via REVDIFF_POPUP_WIDTH / REVDIFF_POPUP_HEIGHT env vars
43+
POPUP_W="${REVDIFF_POPUP_WIDTH:-90%}"
44+
POPUP_H="${REVDIFF_POPUP_HEIGHT:-90%}"
45+
3846
# tmux: display-popup -E blocks until command exits
3947
if [ -n "${TMUX:-}" ] && command -v tmux >/dev/null 2>&1; then
40-
tmux display-popup -E -w 90% -h 90% -T " $OVERLAY_TITLE " -d "$CWD" -- sh -c "$REVDIFF_CMD"
48+
tmux display-popup -E -w "$POPUP_W" -h "$POPUP_H" -T " $OVERLAY_TITLE " -d "$CWD" -- sh -c "$REVDIFF_CMD"
4149
cat "$OUTPUT_FILE"
4250
exit 0
4351
fi

0 commit comments

Comments
 (0)