GetOrCreateCachedTempOrderAsync() include failed/exception details from CreateTempOrderAsync()

[tf-lait]

Which component is this idea for?

Umbraco Commerce (Core)

Describe your idea

I thought about creating an issue, but for now I'll park this a suggestion / feature request.

I ran into "Failed to create temporary order for price calculation" using TryCalculatePriceWithAdjustmentsAsync() using Umbraco 16.3.

After a deep-dive into Umbraco Commerce internals I found that CreateTempOrderAsync() threw an exception with "Shipping Method is not allowed in orders shipping country / region" but that fail-state / exception is discarded.

So could you eiher:
A) Combine the two exceptions/messages either be be combined into: "Failed to create temporary order for price calculation. Cause: Shipping Method is not allowed in orders shipping country / region" or use AggregateException?
B) Simply throw the exception from CreateTempOrderAsync() instead of "Failed to create temporary order for price calculation"?

Context

No response

[mattbrailsford]

That’s a good suggestion. I’ll get this added to our backlog to take a lot at in a future sprint.

Thanks for doing the digging 🙏