Link type is External with only querystring

[bjarnef]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.6.0

Bug summary

I noticed when just specifying anchor/querystring the link type is considered External.

I don't think this is correct assumption as it is mostly linking to same page or other page via anchor/querystring.

I think the following should be considered as Content link type (or perhaps we need a new Internal link type?), when following conditions are met:

• Anchor/querystring has value (contains at least ? and/or #).
• destinationId is null.
• url property is empty or is equal to queryString (previously it seems url could be null, while querystring had a value, but it may be related to change in Add query string info to links in API output #15327 that querystring is included in url property now).

The reason for this it that we typically want to open External links in new tab/window, while internal links opens in same window/tab unless link to a document/file.

Specifics

No response

Steps to reproduce

Expected result / actual result

No response

[github-actions]

Hi there @bjarnef!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂